Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1090313003: Correctly align and ellipsize PDF titles in material design PDF viewer (Closed)

Created:
5 years, 8 months ago by tsergeant
Modified:
5 years, 8 months ago
Reviewers:
raymes
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly align and ellipsize PDF titles in material design PDF viewer This ensures that the PDF title will be truncated with ellipses if it is too long, rather than pushing out the other controls to the right. Also URL decode the title to remove ugly encoded characters. BUG=439114 Committed: https://crrev.com/676964bcdaf619bf743ae624e9b81ef856d1e29c Cr-Commit-Position: refs/heads/master@{#327010}

Patch Set 1 #

Patch Set 2 : Overflow page numbers nicely #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -8 lines) Patch
M chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.css View 1 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.html View 1 1 chunk +10 lines, -6 lines 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
tsergeant
raymes@, can you please review?
5 years, 8 months ago (2015-04-21 03:45:35 UTC) #3
raymes
This looks good! We haven't really thought about testing for the new UI but maybe ...
5 years, 8 months ago (2015-04-21 06:29:28 UTC) #4
tsergeant
On 2015/04/21 06:29:28, raymes wrote: > This looks good! We haven't really thought about testing ...
5 years, 8 months ago (2015-04-27 03:55:15 UTC) #5
raymes
lgtm
5 years, 8 months ago (2015-04-27 06:25:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090313003/40001
5 years, 8 months ago (2015-04-27 06:34:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/18774)
5 years, 8 months ago (2015-04-27 06:37:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090313003/60001
5 years, 8 months ago (2015-04-27 06:49:29 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 8 months ago (2015-04-27 07:41:22 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 07:42:22 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/676964bcdaf619bf743ae624e9b81ef856d1e29c
Cr-Commit-Position: refs/heads/master@{#327010}

Powered by Google App Engine
This is Rietveld 408576698