Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: lib/runtime/dart/isolate.js

Issue 1090313002: fixes #52, fields shadowing getters/setters or other fields (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/core.js ('k') | lib/runtime/dart/math.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/isolate.js
diff --git a/lib/runtime/dart/isolate.js b/lib/runtime/dart/isolate.js
index ff74032313e2feab347aae6729c9674ba3707a1d..1151aa6c30ee835d64a498c360a40261cbc29d0e 100644
--- a/lib/runtime/dart/isolate.js
+++ b/lib/runtime/dart/isolate.js
@@ -6,24 +6,40 @@ var isolate;
return new _isolate_helper.CapabilityImpl();
}
}
+ let message$ = Symbol('message');
class IsolateSpawnException extends core.Object {
+ get message() {
+ return this[message$];
+ }
IsolateSpawnException(message) {
- this.message = message;
+ this[message$] = message;
}
toString() {
return `IsolateSpawnException: ${this.message}`;
}
}
IsolateSpawnException[dart.implements] = () => [core.Exception];
+ let controlPort$ = Symbol('controlPort');
+ let pauseCapability$ = Symbol('pauseCapability');
+ let terminateCapability$ = Symbol('terminateCapability');
let _currentIsolateCache = Symbol('_currentIsolateCache');
let _pause = Symbol('_pause');
class Isolate extends core.Object {
+ get controlPort() {
+ return this[controlPort$];
+ }
+ get pauseCapability() {
+ return this[pauseCapability$];
+ }
+ get terminateCapability() {
+ return this[terminateCapability$];
+ }
Isolate(controlPort, opts) {
let pauseCapability = opts && 'pauseCapability' in opts ? opts.pauseCapability : null;
let terminateCapability = opts && 'terminateCapability' in opts ? opts.terminateCapability : null;
- this.controlPort = controlPort;
- this.pauseCapability = pauseCapability;
- this.terminateCapability = terminateCapability;
+ this[controlPort$] = controlPort;
+ this[pauseCapability$] = pauseCapability;
+ this[terminateCapability$] = terminateCapability;
}
static get current() {
return Isolate[_currentIsolateCache];
@@ -189,11 +205,15 @@ var isolate;
}
}
_IsolateUnhandledException[dart.implements] = () => [core.Exception];
+ let stackTrace = Symbol('stackTrace');
let _description = Symbol('_description');
class RemoteError extends core.Object {
+ get stackTrace() {
+ return this[stackTrace];
+ }
RemoteError(description, stackDescription) {
this[_description] = description;
- this.stackTrace = new _RemoteStackTrace(stackDescription);
+ this[stackTrace] = new _RemoteStackTrace(stackDescription);
}
toString() {
return this[_description];
« no previous file with comments | « lib/runtime/dart/core.js ('k') | lib/runtime/dart/math.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698