Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1090303004: [turbofan] Add a debug_name to Parameter operators. (Closed)

Created:
5 years, 8 months ago by titzer
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add a debug_name to Parameter operators. R=bmeurer@chromium.org, mstarzinger@chromium.org BUG= Committed: https://crrev.com/ab49ec14e3ca2dccd4638643915d41704f37f2d7 Cr-Commit-Position: refs/heads/master@{#28002}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -38 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 5 chunks +24 lines, -7 lines 0 comments Download
M src/compiler/common-operator.h View 1 2 chunks +22 lines, -1 line 0 comments Download
M src/compiler/common-operator.cc View 3 chunks +48 lines, -13 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/verifier.cc View 4 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
titzer
5 years, 8 months ago (2015-04-22 09:40:13 UTC) #1
Benedikt Meurer
LGTM https://codereview.chromium.org/1090303004/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1090303004/diff/1/src/compiler/ast-graph-builder.cc#newcode592 src/compiler/ast-graph-builder.cc:592: Nit: missing new line (presubmit should have complained ...
5 years, 8 months ago (2015-04-22 09:47:12 UTC) #2
titzer
https://codereview.chromium.org/1090303004/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1090303004/diff/1/src/compiler/ast-graph-builder.cc#newcode592 src/compiler/ast-graph-builder.cc:592: On 2015/04/22 09:47:12, Benedikt Meurer wrote: > Nit: missing ...
5 years, 8 months ago (2015-04-22 09:50:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090303004/20001
5 years, 8 months ago (2015-04-22 09:50:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/5153)
5 years, 8 months ago (2015-04-22 10:20:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090303004/20001
5 years, 8 months ago (2015-04-22 11:20:03 UTC) #10
Michael Achenbach
Mac issue should be fixed...
5 years, 8 months ago (2015-04-22 11:20:28 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-22 11:34:48 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 13:19:30 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab49ec14e3ca2dccd4638643915d41704f37f2d7
Cr-Commit-Position: refs/heads/master@{#28002}

Powered by Google App Engine
This is Rietveld 408576698