Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: core/src/fxcrt/fx_basic_bstring_unittest.cpp

Issue 1090303003: Add missing operators for CFX_ByteStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <map>
6
5 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
6 #include "../../../testing/fx_string_testhelpers.h" 8 #include "../../../testing/fx_string_testhelpers.h"
7 #include "../../include/fxcrt/fx_basic.h" 9 #include "../../include/fxcrt/fx_basic.h"
8 10
9 TEST(fxcrt, ByteStringCNull) { 11 TEST(fxcrt, ByteStringCNull) {
10 CFX_ByteStringC null_string; 12 CFX_ByteStringC null_string;
11 EXPECT_EQ(null_string.GetPtr(), nullptr); 13 EXPECT_EQ(null_string.GetPtr(), nullptr);
12 EXPECT_EQ(null_string.GetLength(), 0); 14 EXPECT_EQ(null_string.GetLength(), 0);
13 EXPECT_TRUE(null_string.IsEmpty()); 15 EXPECT_TRUE(null_string.IsEmpty());
14 16
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 CFX_ByteString short_string("a"); 185 CFX_ByteString short_string("a");
184 CFX_ByteString longer_string("abc"); 186 CFX_ByteString longer_string("abc");
185 CFX_ByteString embedded_nul_string("ab\0c", 4); 187 CFX_ByteString embedded_nul_string("ab\0c", 4);
186 188
187 EXPECT_EQ('a', short_string.GetAt(0)); 189 EXPECT_EQ('a', short_string.GetAt(0));
188 EXPECT_EQ('c', longer_string.GetAt(2)); 190 EXPECT_EQ('c', longer_string.GetAt(2));
189 EXPECT_EQ('b', embedded_nul_string.GetAt(1)); 191 EXPECT_EQ('b', embedded_nul_string.GetAt(1));
190 EXPECT_EQ('\0', embedded_nul_string.GetAt(2)); 192 EXPECT_EQ('\0', embedded_nul_string.GetAt(2));
191 EXPECT_EQ('c', embedded_nul_string.GetAt(3)); 193 EXPECT_EQ('c', embedded_nul_string.GetAt(3));
192 } 194 }
195
196 TEST(fxcrt, ByteStringCOperatorSubscript) {
197 // CFX_ByteStringC includes the NUL terminator for non-empty strings.
198 CFX_ByteStringC abc("abc");
199 EXPECT_EQ('a', abc[0]);
200 EXPECT_EQ('b', abc[1]);
201 EXPECT_EQ('c', abc[2]);
202 EXPECT_EQ(0, abc[3]);
203 }
204
205 TEST(fxcrt, ByteStringCOperatorLT) {
206 CFX_ByteStringC empty;
207 CFX_ByteStringC a("a");
208 CFX_ByteStringC abc("abc");
209
210 EXPECT_FALSE(empty < empty);
211 EXPECT_FALSE(a < a);
212 EXPECT_FALSE(abc < abc);
213
214 EXPECT_TRUE(empty < a);
215 EXPECT_FALSE(a < empty);
216
217 EXPECT_TRUE(empty < abc);
218 EXPECT_FALSE(abc < empty);
219
220 EXPECT_TRUE(a < abc);
221 EXPECT_FALSE(abc < a);
222 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698