Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1415)

Unified Diff: runtime/vm/pages.cc

Issue 1090293003: Kill service_test.cc tests in favor of dart tests for the service protocol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/pages.cc
diff --git a/runtime/vm/pages.cc b/runtime/vm/pages.cc
index 9f33942e6d218da171453e33d605d1e0354e3cc0..7d7c45e6956241a4cb1ffec4941bf4b3f95f1b27 100644
--- a/runtime/vm/pages.cc
+++ b/runtime/vm/pages.cc
@@ -668,14 +668,13 @@ class HeapMapAsJSONVisitor : public ObjectVisitor {
void PageSpace::PrintHeapMapToJSONStream(Isolate* isolate, JSONStream* stream) {
JSONObject heap_map(stream);
heap_map.AddProperty("type", "HeapMap");
- heap_map.AddProperty("id", "heapmap");
- heap_map.AddProperty("free_class_id",
+ heap_map.AddProperty("freeClassId",
static_cast<intptr_t>(kFreeListElement));
- heap_map.AddProperty("unit_size_bytes",
+ heap_map.AddProperty("unitSizeBytes",
static_cast<intptr_t>(kObjectAlignment));
- heap_map.AddProperty("page_size_bytes", kPageSizeInWords * kWordSize);
+ heap_map.AddProperty("pageSizeBytes", kPageSizeInWords * kWordSize);
{
- JSONObject class_list(&heap_map, "class_list");
+ JSONObject class_list(&heap_map, "classList");
isolate->class_table()->PrintToJSONObject(&class_list);
}
{
@@ -688,7 +687,7 @@ void PageSpace::PrintHeapMapToJSONStream(Isolate* isolate, JSONStream* stream) {
JSONArray all_pages(&heap_map, "pages");
for (HeapPage* page = pages_; page != NULL; page = page->next()) {
JSONObject page_container(&all_pages);
- page_container.AddPropertyF("object_start",
+ page_container.AddPropertyF("objectStart",
"0x%" Px "", page->object_start());
JSONArray page_map(&page_container, "objects");
HeapMapAsJSONVisitor printer(&page_map);
@@ -696,7 +695,7 @@ void PageSpace::PrintHeapMapToJSONStream(Isolate* isolate, JSONStream* stream) {
}
for (HeapPage* page = exec_pages_; page != NULL; page = page->next()) {
JSONObject page_container(&all_pages);
- page_container.AddPropertyF("object_start",
+ page_container.AddPropertyF("objectStart",
"0x%" Px "", page->object_start());
JSONArray page_map(&page_container, "objects");
HeapMapAsJSONVisitor printer(&page_map);
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698