runtime/observatory/tests/service/test_helper.dart - Issue 1090293003: Kill service_test.cc tests in favor of dart tests for the service protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/test_helper.dart

Issue 1090293003: Kill service_test.cc tests in favor of dart tests for the service protocol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fix tests Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/service/string_escaping_test.dart ('k') | runtime/observatory/tests/service/type_arguments_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/service/test_helper.dart

diff --git a/runtime/observatory/tests/service/test_helper.dart b/runtime/observatory/tests/service/test_helper.dart

index 3dddedd351cc0760ff8cbd4df2c7b3a6bf1d72b9..34b7a431c2f83bedc8836385ae842d9de325d3e5 100644

--- a/runtime/observatory/tests/service/test_helper.dart

+++ b/runtime/observatory/tests/service/test_helper.dart

@@ -106,8 +106,8 @@ void runIsolateTests(List<String> mainArgs,

var process = new _TestLauncher();

process.launch(pause_on_exit).then((port) {

String addr = 'ws://localhost:$port/ws';

- var testIndex = 0;

- var totalTests = tests.length - 1;

+ var testIndex = 1;

+ var totalTests = tests.length;

var name = Platform.script.pathSegments.last;

runZoned(() {

new WebSocketVM(new WebSocketVMTarget(addr)).load()

@@ -167,8 +167,8 @@ Future runVMTests(List<String> mainArgs,