components/nacl/renderer/ppb_nacl_private.h - Issue 1090233003: Set up a NaCl load status callback to start replacing "start_module".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/renderer/ppb_nacl_private.h

Issue 1090233003: Set up a NaCl load status callback to start replacing "start_module". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add back old comment Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/nacl/common/nacl_renderer_messages.h ('K') | « components/nacl/renderer/plugin/service_runtime.cc ('k') | components/nacl/renderer/ppb_nacl_private_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/renderer/ppb_nacl_private.h

diff --git a/components/nacl/renderer/ppb_nacl_private.h b/components/nacl/renderer/ppb_nacl_private.h

index 7953461bac2de29967b26af4dcf2ba4ab6aacd6b..26836521873ac9cdcc5b7a25aa39974eff459e71 100644

--- a/components/nacl/renderer/ppb_nacl_private.h

+++ b/components/nacl/renderer/ppb_nacl_private.h

@@ -326,13 +326,6 @@ struct PPB_NaCl_Private {

const char* url,

struct PP_NaClFileInfo* file_info,

struct PP_CompletionCallback callback);

- /* Reports the status of sel_ldr for UMA reporting.

- * |max_status| has to be provided because the implementation of this

- * interface can't access the NaClErrorCode enum.

- */

- void (*ReportSelLdrStatus)(PP_Instance instance,

- int32_t load_status,

- int32_t max_status);

/* Logs time taken by an operation to UMA histograms.

* This function is safe to call on any thread.

@@ -365,4 +358,3 @@ struct PPB_NaCl_Private {

#endif /* COMPONENTS_NACL_RENDERER_PPB_NACL_PRIVATE_H_ */