components/nacl/renderer/ppb_nacl_private_impl.cc - Issue 1090233003: Set up a NaCl load status callback to start replacing "start_module".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/renderer/ppb_nacl_private_impl.cc

Issue 1090233003: Set up a NaCl load status callback to start replacing "start_module". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/nacl/renderer/plugin/service_runtime.cc ('K') | « components/nacl/renderer/plugin/service_runtime.cc ('k') | components/nacl/renderer/trusted_plugin_channel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/renderer/ppb_nacl_private_impl.cc

diff --git a/components/nacl/renderer/ppb_nacl_private_impl.cc b/components/nacl/renderer/ppb_nacl_private_impl.cc

index c879e48671bf9e1cb00fc42c3325ba6d162bf16f..63c69b9badc53d7f940f09db41bcae7da91ddddc 100644

--- a/components/nacl/renderer/ppb_nacl_private_impl.cc

+++ b/components/nacl/renderer/ppb_nacl_private_impl.cc

@@ -501,13 +501,13 @@ void LaunchSelLdr(PP_Instance instance,

// Create the trusted plugin channel.

if (IsValidChannelHandle(launch_result.trusted_ipc_channel_handle)) {

- bool report_exit_status = PP_ToBool(main_service_runtime);

+ bool is_helper_nexe = !PP_ToBool(main_service_runtime);

scoped_ptr<TrustedPluginChannel> trusted_plugin_channel(

new TrustedPluginChannel(

load_manager,

launch_result.trusted_ipc_channel_handle,

content::RenderThread::Get()->GetShutdownEvent(),

- report_exit_status));

+ is_helper_nexe));

load_manager->set_trusted_plugin_channel(trusted_plugin_channel.Pass());

} else {

PostPPCompletionCallback(callback, PP_ERROR_FAILED);