components/nacl/renderer/plugin/service_runtime.h - Issue 1090233003: Set up a NaCl load status callback to start replacing "start_module".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/renderer/plugin/service_runtime.h

Issue 1090233003: Set up a NaCl load status callback to start replacing "start_module". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use the enum instead of int Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/nacl/renderer/plugin/service_runtime.h

diff --git a/components/nacl/renderer/plugin/service_runtime.h b/components/nacl/renderer/plugin/service_runtime.h

index 5fe941a1f4e35442ba1f6866366adeefb0593437..f1991b6271a2e57b6ca9e3e1c150b55aeefd6aac 100644

--- a/components/nacl/renderer/plugin/service_runtime.h

+++ b/components/nacl/renderer/plugin/service_runtime.h

@@ -85,7 +85,6 @@ class ServiceRuntime {

// Starts the application channel to the nexe.

SrpcClient* SetupAppChannel();

- bool RemoteLog(int severity, const std::string& msg);

Plugin* plugin() const { return plugin_; }

void Shutdown();

@@ -97,7 +96,6 @@ class ServiceRuntime {

bool SetupCommandChannel();

bool StartModule();

- void ReapLogs();

void ReportLoadError(const ErrorInfo& error_info);

« no previous file with comments | « components/nacl/renderer/DEPS ('k') | components/nacl/renderer/plugin/service_runtime.cc » ('j') | no next file with comments »