Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 109023011: Do not use CalledByNativeUnchecked (Closed)

Created:
6 years, 11 months ago by sgurun-gerrit only
Modified:
6 years, 11 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Do not use CalledByNativeUnchecked The preferred method is to handle exceptions in java code. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -28 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AndroidProtocolHandler.java View 3 chunks +30 lines, -25 lines 0 comments Download
M android_webview/native/android_protocol_handler.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sgurun-gerrit only
PTAL, thanks,
6 years, 11 months ago (2014-01-04 01:23:34 UTC) #1
Kristian Monsen
lgtm, should probably get a lgtm from Marcus.
6 years, 11 months ago (2014-01-04 01:32:54 UTC) #2
bulach
lgtm, thanks for the cleanup! :)
6 years, 11 months ago (2014-01-06 23:06:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sgurun@chromium.org/109023011/1
6 years, 11 months ago (2014-01-07 09:52:51 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43486
6 years, 11 months ago (2014-01-07 10:17:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sgurun@chromium.org/109023011/1
6 years, 11 months ago (2014-01-07 17:08:40 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43534
6 years, 11 months ago (2014-01-07 17:31:35 UTC) #7
boliu
lgtm stamp
6 years, 11 months ago (2014-01-07 18:03:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sgurun@chromium.org/109023011/1
6 years, 11 months ago (2014-01-07 19:29:56 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 22:04:42 UTC) #10
Message was sent while issue was closed. 
Change committed as 243398

Powered by Google App Engine
This is Rietveld 408576698