Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 109023005: Add lock/unlock keyboard menu to virtual keyboard (Closed)

Created:
7 years ago by bshe
Modified:
7 years ago
Reviewers:
SteveT, rsadam
CC:
chromium-reviews
Visibility:
Public.

Description

Add lock/unlock keyboard menu to virtual keyboard BUG=326170 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241192

Patch Set 1 #

Patch Set 2 : #

Total comments: 10

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -7 lines) Patch
M ui/keyboard/resources/api_adapter.js View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M ui/keyboard/resources/elements/kb-options-menu.html View 1 2 3 4 chunks +34 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
bshe
Hey Raheem. Could you take a look at this CL? It implement a lock/unlock menu ...
7 years ago (2013-12-13 20:08:49 UTC) #1
bshe
On 2013/12/13 20:08:49, bshe wrote: > Hey Raheem. > > Could you take a look ...
7 years ago (2013-12-13 20:09:30 UTC) #2
rsadam
https://codereview.chromium.org/109023005/diff/20001/ui/keyboard/resources/api_adapter.js File ui/keyboard/resources/api_adapter.js (right): https://codereview.chromium.org/109023005/diff/20001/ui/keyboard/resources/api_adapter.js#newcode46 ui/keyboard/resources/api_adapter.js:46: * @param {boolean} lock True if lock virtual keyboard. ...
7 years ago (2013-12-13 22:09:13 UTC) #3
bshe
Thanks Raheem. I have addressed all the comments. +stevet as well https://codereview.chromium.org/109023005/diff/20001/ui/keyboard/resources/api_adapter.js File ui/keyboard/resources/api_adapter.js (right): ...
7 years ago (2013-12-16 14:57:56 UTC) #4
rsadam
lgtm
7 years ago (2013-12-16 15:16:53 UTC) #5
SteveT
PTAL at my questions.. https://codereview.chromium.org/109023005/diff/20001/ui/keyboard/resources/elements/kb-options-menu.html File ui/keyboard/resources/elements/kb-options-menu.html (right): https://codereview.chromium.org/109023005/diff/20001/ui/keyboard/resources/elements/kb-options-menu.html#newcode62 ui/keyboard/resources/elements/kb-options-menu.html:62: var LOCK_KEY_LABEL = 'Lock'; 'Lock' ...
7 years ago (2013-12-16 15:45:11 UTC) #6
bshe
https://codereview.chromium.org/109023005/diff/20001/ui/keyboard/resources/elements/kb-options-menu.html File ui/keyboard/resources/elements/kb-options-menu.html (right): https://codereview.chromium.org/109023005/diff/20001/ui/keyboard/resources/elements/kb-options-menu.html#newcode62 ui/keyboard/resources/elements/kb-options-menu.html:62: var LOCK_KEY_LABEL = 'Lock'; Good point. We dont have ...
7 years ago (2013-12-16 16:06:00 UTC) #7
SteveT
Okay then. LGTM for Chromium approval.
7 years ago (2013-12-16 16:06:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/109023005/60001
7 years ago (2013-12-16 16:07:47 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204815
7 years ago (2013-12-16 16:57:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/109023005/60001
7 years ago (2013-12-16 21:20:21 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=205248
7 years ago (2013-12-16 23:02:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/109023005/60001
7 years ago (2013-12-17 05:03:47 UTC) #13
commit-bot: I haz the power
7 years ago (2013-12-17 07:43:09 UTC) #14
Message was sent while issue was closed.
Change committed as 241192

Powered by Google App Engine
This is Rietveld 408576698