Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: chrome/chrome.gyp

Issue 1090213002: optimize branding - use branding_path_component variable for defining pranding specific paths (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed conditional branding Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome.gyp
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp
index 55d9dce8ce86511af395982a35c943ac87cbd3c3..46108eedf7e72761cbc0e7a4d56eec1025712f58 100644
--- a/chrome/chrome.gyp
+++ b/chrome/chrome.gyp
@@ -411,20 +411,10 @@
{
'target_name': 'chrome_version_resources',
'type': 'none',
- 'conditions': [
- ['branding == "Chrome"', {
- 'variables': {
- 'branding_path': 'app/theme/google_chrome/BRANDING',
- },
- }, { # else branding!="Chrome"
- 'variables': {
- 'branding_path': 'app/theme/chromium/BRANDING',
- },
- }],
- ],
'variables': {
'output_dir': 'chrome_version',
'template_input_path': 'app/chrome_version.rc.version',
+ 'branding_path': 'app/theme/<(branding_path_component)/BRANDING',
},
'direct_dependent_settings': {
'include_dirs': [
@@ -452,18 +442,8 @@
'variables': {
'lastchange_path':
'<(DEPTH)/build/util/LASTCHANGE',
+ 'branding_path': 'app/theme/<(branding_path_component)/BRANDING',
},
- 'conditions': [
- ['branding == "Chrome"', {
- 'variables': {
- 'branding_path': 'app/theme/google_chrome/BRANDING',
- },
- }, { # else branding!="Chrome"
- 'variables': {
- 'branding_path': 'app/theme/chromium/BRANDING',
- },
- }],
- ],
'inputs': [
'<(version_path)',
'<(branding_path)',
« no previous file with comments | « build/common.gypi ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698