Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: chrome/chrome_exe.gypi

Issue 1090213002: optimize branding - use branding_path_component variable for defining pranding specific paths (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed conditional branding Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/chrome_installer.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name': 'chrome', 8 'target_name': 'chrome',
9 'type': 'none', 9 'type': 'none',
10 'dependencies': [ 'chrome_initial', ], 10 'dependencies': [ 'chrome_initial', ],
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 ], 309 ],
310 'actions': [ 310 'actions': [
311 { 311 {
312 # Generate the InfoPlist.strings file 312 # Generate the InfoPlist.strings file
313 'action_name': 'Generate InfoPlist.strings files', 313 'action_name': 'Generate InfoPlist.strings files',
314 'variables': { 314 'variables': {
315 'tool_path': '<(PRODUCT_DIR)/infoplist_strings_tool', 315 'tool_path': '<(PRODUCT_DIR)/infoplist_strings_tool',
316 # Unique dir to write to so the [lang].lproj/InfoPlist.strings 316 # Unique dir to write to so the [lang].lproj/InfoPlist.strings
317 # for the main app and the helper app don't name collide. 317 # for the main app and the helper app don't name collide.
318 'output_path': '<(INTERMEDIATE_DIR)/app_infoplist_strings', 318 'output_path': '<(INTERMEDIATE_DIR)/app_infoplist_strings',
319 'branding_name': '<(branding_path_component)_strings',
319 }, 320 },
320 'conditions': [
321 [ 'branding == "Chrome"', {
322 'variables': {
323 'branding_name': 'google_chrome_strings',
324 },
325 }, { # else branding!="Chrome"
326 'variables': {
327 'branding_name': 'chromium_strings',
328 },
329 }],
330 ],
331 'inputs': [ 321 'inputs': [
332 '<(tool_path)', 322 '<(tool_path)',
333 '<(version_path)', 323 '<(version_path)',
334 # TODO: remove this helper when we have loops in GYP 324 # TODO: remove this helper when we have loops in GYP
335 '>!@(<(apply_locales_cmd) \'<(grit_out_dir)/<(branding_name)_ZZL OCALE.pak\' <(locales))', 325 '>!@(<(apply_locales_cmd) \'<(grit_out_dir)/<(branding_name)_ZZL OCALE.pak\' <(locales))',
336 ], 326 ],
337 'outputs': [ 327 'outputs': [
338 # TODO: remove this helper when we have loops in GYP 328 # TODO: remove this helper when we have loops in GYP
339 '>!@(<(apply_locales_cmd) -d \'<(output_path)/ZZLOCALE.lproj/Inf oPlist.strings\' <(locales))', 329 '>!@(<(apply_locales_cmd) -d \'<(output_path)/ZZLOCALE.lproj/Inf oPlist.strings\' <(locales))',
340 ], 330 ],
(...skipping 353 matching lines...) Expand 10 before | Expand all | Expand 10 after
694 'dependencies': [ 684 'dependencies': [
695 'chrome_nacl_win64', 685 'chrome_nacl_win64',
696 ], 686 ],
697 }], 687 }],
698 ], 688 ],
699 }, 689 },
700 ], 690 ],
701 }], 691 }],
702 ], 692 ],
703 } 693 }
OLDNEW
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/chrome_installer.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698