Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: build/common.gypi

Issue 1090213002: optimize branding - use branding_path_component variable for defining pranding specific paths (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed conditional branding Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 'use_cras%': '<(use_cras)', 142 'use_cras%': '<(use_cras)',
143 'use_ozone%': '<(use_ozone)', 143 'use_ozone%': '<(use_ozone)',
144 'embedded%': '<(embedded)', 144 'embedded%': '<(embedded)',
145 'use_libpci%': '<(use_libpci)', 145 'use_libpci%': '<(use_libpci)',
146 'use_openssl%': '<(use_openssl)', 146 'use_openssl%': '<(use_openssl)',
147 'use_openssl_certs%': '<(use_openssl_certs)', 147 'use_openssl_certs%': '<(use_openssl_certs)',
148 'enable_viewport%': '<(enable_viewport)', 148 'enable_viewport%': '<(enable_viewport)',
149 'enable_hidpi%': '<(enable_hidpi)', 149 'enable_hidpi%': '<(enable_hidpi)',
150 'buildtype%': '<(buildtype)', 150 'buildtype%': '<(buildtype)',
151 'branding%': '<(branding)', 151 'branding%': '<(branding)',
152 'branding_path_component%': '<(branding)',
152 'host_arch%': '<(host_arch)', 153 'host_arch%': '<(host_arch)',
153 'target_arch%': '<(target_arch)', 154 'target_arch%': '<(target_arch)',
154 155
155 'target_subarch%': '', 156 'target_subarch%': '',
156 157
157 # The channel to build on Android: stable, beta, dev, canary, or 158 # The channel to build on Android: stable, beta, dev, canary, or
158 # default. "default" should be used on non-official builds. 159 # default. "default" should be used on non-official builds.
159 'android_channel%': 'default', 160 'android_channel%': 'default',
160 161
161 # Set ARM architecture version. 162 # Set ARM architecture version.
(...skipping 19 matching lines...) Expand all
181 # below for MIPS targets. 182 # below for MIPS targets.
182 'mips_arch_variant%': '', 183 'mips_arch_variant%': '',
183 184
184 # MIPS DSP ASE revision. Possible values are: 185 # MIPS DSP ASE revision. Possible values are:
185 # 0: unavailable 186 # 0: unavailable
186 # 1: revision 1 187 # 1: revision 1
187 # 2: revision 2 188 # 2: revision 2
188 'mips_dsp_rev%': 0, 189 'mips_dsp_rev%': 0,
189 190
190 'conditions': [ 191 'conditions': [
192 ['branding == "Chrome"', {
193 'branding_path_component%': 'google_chrome',
194 }],
195
196 ['branding == "Chromium"', {
197 'branding_path_component%': 'chromium',
198 }],
199
191 # Ash needs Aura. 200 # Ash needs Aura.
192 ['use_aura==0', { 201 ['use_aura==0', {
193 'use_ash%': 0, 202 'use_ash%': 0,
194 }], 203 }],
195 204
196 # Set default value of toolkit_views based on OS. 205 # Set default value of toolkit_views based on OS.
197 ['OS=="mac" or OS=="win" or chromeos==1 or use_aura==1', { 206 ['OS=="mac" or OS=="win" or chromeos==1 or use_aura==1', {
198 'toolkit_views%': 1, 207 'toolkit_views%': 1,
199 }, { 208 }, {
200 'toolkit_views%': 0, 209 'toolkit_views%': 0,
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 'use_openssl_certs%': '<(use_openssl_certs)', 297 'use_openssl_certs%': '<(use_openssl_certs)',
289 'enable_viewport%': '<(enable_viewport)', 298 'enable_viewport%': '<(enable_viewport)',
290 'enable_hidpi%': '<(enable_hidpi)', 299 'enable_hidpi%': '<(enable_hidpi)',
291 'android_channel%': '<(android_channel)', 300 'android_channel%': '<(android_channel)',
292 'use_goma%': '<(use_goma)', 301 'use_goma%': '<(use_goma)',
293 'gomadir%': '<(gomadir)', 302 'gomadir%': '<(gomadir)',
294 'enable_app_list%': '<(enable_app_list)', 303 'enable_app_list%': '<(enable_app_list)',
295 'use_default_render_theme%': '<(use_default_render_theme)', 304 'use_default_render_theme%': '<(use_default_render_theme)',
296 'buildtype%': '<(buildtype)', 305 'buildtype%': '<(buildtype)',
297 'branding%': '<(branding)', 306 'branding%': '<(branding)',
307 'branding_path_component%': '<(branding_path_component)',
298 'arm_version%': '<(arm_version)', 308 'arm_version%': '<(arm_version)',
299 'sysroot%': '<(sysroot)', 309 'sysroot%': '<(sysroot)',
300 'chroot_cmd%': '<(chroot_cmd)', 310 'chroot_cmd%': '<(chroot_cmd)',
301 'system_libdir%': '<(system_libdir)', 311 'system_libdir%': '<(system_libdir)',
302 312
303 # Set to 1 to enable fast builds. Set to 2 for even faster builds 313 # Set to 1 to enable fast builds. Set to 2 for even faster builds
304 # (it disables debug info for fastest compilation - only for use 314 # (it disables debug info for fastest compilation - only for use
305 # on compile-only bots). 315 # on compile-only bots).
306 'fastbuild%': 0, 316 'fastbuild%': 0,
307 317
(...skipping 751 matching lines...) Expand 10 before | Expand all | Expand 10 after
1059 'disable_nacl%': '0', 1069 'disable_nacl%': '0',
1060 1070
1061 # Sets the default version name and code for Android app, by default we 1071 # Sets the default version name and code for Android app, by default we
1062 # do a developer build. 1072 # do a developer build.
1063 'android_app_version_name%': 'Developer Build', 1073 'android_app_version_name%': 'Developer Build',
1064 'android_app_version_code%': 1, 1074 'android_app_version_code%': 1,
1065 }, 1075 },
1066 1076
1067 # Copy conditionally-set variables out one scope. 1077 # Copy conditionally-set variables out one scope.
1068 'branding%': '<(branding)', 1078 'branding%': '<(branding)',
1079 'branding_path_component%': '<(branding_path_component)',
1069 'buildtype%': '<(buildtype)', 1080 'buildtype%': '<(buildtype)',
1070 'target_arch%': '<(target_arch)', 1081 'target_arch%': '<(target_arch)',
1071 'target_subarch%': '<(target_subarch)', 1082 'target_subarch%': '<(target_subarch)',
1072 'mips_arch_variant%': '<(mips_arch_variant)', 1083 'mips_arch_variant%': '<(mips_arch_variant)',
1073 'mips_dsp_rev%': '<(mips_dsp_rev)', 1084 'mips_dsp_rev%': '<(mips_dsp_rev)',
1074 'host_arch%': '<(host_arch)', 1085 'host_arch%': '<(host_arch)',
1075 'toolkit_views%': '<(toolkit_views)', 1086 'toolkit_views%': '<(toolkit_views)',
1076 'ui_compositor_image_transport%': '<(ui_compositor_image_transport)', 1087 'ui_compositor_image_transport%': '<(ui_compositor_image_transport)',
1077 'use_aura%': '<(use_aura)', 1088 'use_aura%': '<(use_aura)',
1078 'use_ash%': '<(use_ash)', 1089 'use_ash%': '<(use_ash)',
(...skipping 5065 matching lines...) Expand 10 before | Expand all | Expand 10 after
6144 # settings in target dicts. SYMROOT is a special case, because many other 6155 # settings in target dicts. SYMROOT is a special case, because many other
6145 # Xcode variables depend on it, including variables such as 6156 # Xcode variables depend on it, including variables such as
6146 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6157 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6147 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6158 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6148 # files to appear (when present) in the UI as actual files and not red 6159 # files to appear (when present) in the UI as actual files and not red
6149 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6160 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6150 # and therefore SYMROOT, needs to be set at the project level. 6161 # and therefore SYMROOT, needs to be set at the project level.
6151 'SYMROOT': '<(DEPTH)/xcodebuild', 6162 'SYMROOT': '<(DEPTH)/xcodebuild',
6152 }, 6163 },
6153 } 6164 }
OLDNEW
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698