Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: chrome/chrome_installer.gypi

Issue 1090213002: optimize branding - use branding_path_component variable for defining pranding specific paths (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed according to comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« build/common.gypi ('K') | « chrome/chrome_exe.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'lastchange_path': '../build/util/LASTCHANGE', 7 'lastchange_path': '../build/util/LASTCHANGE',
8 'libpeer_target_type%': 'static_library', 8 'libpeer_target_type%': 'static_library',
9 # 'branding_dir' is set in the 'conditions' section at the bottom. 9 'branding_dir': 'app/theme/<(branding_path_component)',
10 'branding_dir_100': 'app/theme/default_100_percent/<(branding_path_component )',
Michael Moss 2015/04/21 18:00:28 FYI, I think since this is moved out of the condit
10 }, 11 },
11 'conditions': [ 12 'conditions': [
12 ['OS=="win"', { 13 ['OS=="win"', {
13 'targets': [ 14 'targets': [
14 { 15 {
15 'target_name': 'gcapi_dll', 16 'target_name': 'gcapi_dll',
16 'type': 'loadable_module', 17 'type': 'loadable_module',
17 'dependencies': [ 18 'dependencies': [
18 'gcapi_lib', 19 'gcapi_lib',
19 ], 20 ],
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 }, 152 },
152 { 153 {
153 # GN version: //chrome/installer/util:strings 154 # GN version: //chrome/installer/util:strings
154 'target_name': 'installer_util_strings', 155 'target_name': 'installer_util_strings',
155 'type': 'none', 156 'type': 'none',
156 'actions': [ 157 'actions': [
157 { 158 {
158 'action_name': 'installer_util_strings', 159 'action_name': 'installer_util_strings',
159 'variables': { 160 'variables': {
160 'create_string_rc_py': 'installer/util/prebuild/create_string_rc .py', 161 'create_string_rc_py': 'installer/util/prebuild/create_string_rc .py',
162 'brand_strings': '<(branding_path_component)_strings',
161 }, 163 },
162 'conditions': [ 164
163 ['branding=="Chrome"', {
164 'variables': {
165 'brand_strings': 'google_chrome_strings',
166 },
167 }, {
168 'variables': {
169 'brand_strings': 'chromium_strings',
170 },
171 }],
172 ],
173 'inputs': [ 165 'inputs': [
174 '<(create_string_rc_py)', 166 '<(create_string_rc_py)',
175 'app/<(brand_strings).grd', 167 'app/<(brand_strings).grd',
176 ], 168 ],
177 'outputs': [ 169 'outputs': [
178 '<(SHARED_INTERMEDIATE_DIR)/installer_util_strings/installer_uti l_strings.h', 170 '<(SHARED_INTERMEDIATE_DIR)/installer_util_strings/installer_uti l_strings.h',
179 '<(SHARED_INTERMEDIATE_DIR)/installer_util_strings/installer_uti l_strings.rc', 171 '<(SHARED_INTERMEDIATE_DIR)/installer_util_strings/installer_uti l_strings.rc',
180 ], 172 ],
181 'action': ['python', 173 'action': ['python',
182 '<(create_string_rc_py)', 174 '<(create_string_rc_py)',
(...skipping 901 matching lines...) Expand 10 before | Expand all | Expand 10 after
1084 ], 1076 ],
1085 'include_dirs': [ 1077 'include_dirs': [
1086 '..', 1078 '..',
1087 ], 1079 ],
1088 'sources': [ 1080 'sources': [
1089 'installer/gcapi_mac/gcapi_example_client.mm', 1081 'installer/gcapi_mac/gcapi_example_client.mm',
1090 ], 1082 ],
1091 }, 1083 },
1092 ], # targets 1084 ], # targets
1093 }], # OS=="mac" 1085 }], # OS=="mac"
1094 [ 'branding == "Chrome"', {
1095 'variables': {
1096 'branding_dir': 'app/theme/google_chrome',
1097 'branding_dir_100': 'app/theme/default_100_percent/google_chrome',
1098 },
1099 }, { # else branding!="Chrome"
1100 'variables': {
1101 'branding_dir': 'app/theme/chromium',
1102 'branding_dir_100': 'app/theme/default_100_percent/chromium',
1103 },
1104 }],
1105 ], 1086 ],
1106 } 1087 }
OLDNEW
« build/common.gypi ('K') | « chrome/chrome_exe.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698