components/password_manager/core/browser/affiliation_utils.h - Issue 1090163004: Add experiment to exercise AffiliationService with dummy data, plus add related UMA histograms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/affiliation_utils.h

Issue 1090163004: Add experiment to exercise AffiliationService with dummy data, plus add related UMA histograms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@update_copy

Patch Set: Comment phrasing. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/affiliation_fetcher.cc ('k') | components/password_manager/core/browser/affiliation_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/affiliation_utils.h

diff --git a/components/password_manager/core/browser/affiliation_utils.h b/components/password_manager/core/browser/affiliation_utils.h

index a50c6c87c811dbf3cef522195d2d9a73f2813d69..b5b95463f267be2e6387dc4fc32f4b5f9bcc1130 100644

--- a/components/password_manager/core/browser/affiliation_utils.h

+++ b/components/password_manager/core/browser/affiliation_utils.h

@@ -185,6 +185,14 @@ bool IsAffiliationBasedMatchingEnabled(const base::CommandLine& command_line);

bool IsPropagatingPasswordChangesToWebCredentialsEnabled(

const base::CommandLine& command_line);

+// Returns whether or not affiliation requests for dummy facets should be

+// triggered as part of an experiment to exercise AffiliationService code before

+// users would get a chance to have any real Android-based credentials. If the

+// main feature is forced enabled/disabled via the command line, the experiment

+// is force enabled/disabled correspondingly.

+bool IsAffiliationRequestsForDummyFacetsEnabled(

+ const base::CommandLine& command_line);

// For logging use only.

std::ostream& operator<<(std::ostream& os, const FacetURI& facet_uri);