Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 1090153007: Fix chrome_shell_java deps (Closed)

Created:
5 years, 8 months ago by cjhopman
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke, aruslan
CC:
chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix chrome_shell_java deps The native parts of dom_distiller will try to register jni methods on startup. This fails if the apk doesn't contain the corresponding java bits. So, even though chrome_shell_apk doesn't actually use the java stuff in dom_distiller_content_java, it still needs to depend on it and include it in the apk. Committed: https://crrev.com/54f851d3f953f1af1d9a7f392d50be6d164d27ac Cr-Commit-Position: refs/heads/master@{#326937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
cjhopman
aruslan: *
5 years, 8 months ago (2015-04-24 23:26:42 UTC) #2
Dirk Pranke
lgtm
5 years, 8 months ago (2015-04-24 23:27:21 UTC) #4
aruslan
lgtm
5 years, 8 months ago (2015-04-24 23:28:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090153007/1
5 years, 8 months ago (2015-04-24 23:32:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 23:54:01 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 23:54:51 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54f851d3f953f1af1d9a7f392d50be6d164d27ac
Cr-Commit-Position: refs/heads/master@{#326937}

Powered by Google App Engine
This is Rietveld 408576698