Issue 1090153005: TestGuestViewManager: Remove unnecessary includes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1090153005: TestGuestViewManager: Remove unnecessary includes (Closed)

Created:
5 years, 8 months ago by Fady Samuel

Modified:
5 years, 8 months ago

Reviewers:
paulmeyer

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

TestGuestViewManager: Remove unnecessary includes It looks like TestGuestViewManager can live in components but it had a bunch of unnecessary includes. This CL removes those includes. BUG=444869 Committed: https://crrev.com/1f21a1f8ee4f13a0fed1c7ad3369439bfa854417 Cr-Commit-Position: refs/heads/master@{#326797}

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -13 lines)			Patch
	M	extensions/browser/guest_view/test_guest_view_manager.cc	View		1 chunk	+1 line, -13 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

paulmeyer

On 2015/04/24 13:18:24, Fady Samuel wrote: Wow, that's a lot of unused includes removed! LGTM!

5 years, 8 months ago (2015-04-24 14:07:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090153005/1

5 years, 8 months ago (2015-04-24 14:09:27 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-24 14:58:48 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1f21a1f8ee4f13a0fed1c7ad3369439bfa854417
Cr-Commit-Position: refs/heads/master@{#326797}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages