Issue 109013007: Remove dead code from LiveNodeListBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109013007: Remove dead code from LiveNodeListBase (Closed)

Created:
6 years, 12 months ago by Inactive

Modified:
6 years, 12 months ago

Reviewers:
abarth-chromium, esprehn, eseidel

CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove dead code from LiveNodeListBase Remove dead code from LiveNodeListBase. The m_isItemRefElementsCacheValid member and its associated getter / setter are never used. R=abarth, esprehn Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164322

Patch Set 1 #

Created: 6 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	Source/core/dom/LiveNodeList.h	View		3 chunks	+0 lines, -5 lines	0 comments	Download
	M	Source/core/dom/LiveNodeList.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

eseidel

If you're excited about node lists, our impl needs some major love: https://bugs.webkit.org/show_bug.cgi?id=98823

6 years, 12 months ago (2013-12-24 20:58:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/109013007/1

6 years, 12 months ago (2013-12-24 21:34:14 UTC) #4

Message was sent while issue was closed.

Change committed as 164322

Expand Messages | Collapse Messages