Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2070)

Unified Diff: chrome/chrome_dll_bundle.gypi

Issue 109013004: Use icudat*.dat file on Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add icudtl.dat only when icu_use_data_file_flag is set Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_dll_bundle.gypi
diff --git a/chrome/chrome_dll_bundle.gypi b/chrome/chrome_dll_bundle.gypi
index dc721ffe865b635d14504fedf4ce2de01f5e165c..f2e31265fad02cf695073c3e95068be8402b3595 100644
--- a/chrome/chrome_dll_bundle.gypi
+++ b/chrome/chrome_dll_bundle.gypi
@@ -68,6 +68,13 @@
# dependency but not copied to the final target. See
# common.gypi for more info.
],
+ 'conditions': [
+ ['icu_use_data_file_flag', {
Mark Mentovai 2013/12/18 19:04:04 It’s more usual to write icu_use_data_file_flag
jungshik at Google 2013/12/18 19:53:19 will do
+ 'mac_bundle_resources': [
+ '<(DEPTH)/third_party/icu/source/data/in/icudtl.dat',
Mark Mentovai 2013/12/18 19:04:04 Did you have something else copy the data file to
jungshik at Google 2013/12/18 19:53:19 There's a mac_bundle_resources {} right above my a
+ ],
+ }],
+ ],
'mac_bundle_resources!': [
'app/framework-Info.plist',
],

Powered by Google App Engine
This is Rietveld 408576698