Use icudat*.dat file on Mac

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
   'variables': {
     # Putting a variables dict inside another variables dict looks kind of

[Mark Mentovai, 2013/12/18 19:04:04]

At first, I thought that this comment might be what your problem was, but now I
don’t think so. For reference, I was going to suggest doing roughly

  'variables': {
    'variables': {
      'icu_use_data_file_flag%': 0,
    },
    'icu_use_data_file_flag%': '<(icu_use_data_file_flag)',
    'conditions': [
      ['OS=="mac"', {
        'icu_use_data_file_flag%': 1,
      }],
    ],
  },

but I don’t think that would make a difference, because you don’t use
icu_use_data_file_flag in a conditions block in a context where it might be a
problem.

     # weird.  This is done so that 'host_arch', 'chromeos', etc are defined as
     # variables within the outer variables dict here.  This is necessary
     # to get these variables defined for the conditions within this variables
     # dict that operate on these variables.
     'variables': {
       'variables': {
         'variables': {
           'variables': {
             # Whether we're building a ChromeOS build.
             'chromeos%': 0,
@@ skipping 1272 matching lines @@
             'sysroot%': '<(sysroot)',
             'CXX%': '<(CXX)',
           }],
           # All Chrome builds have breakpad symbols, but only process the
           # symbols from official builds.
           ['(branding=="Chrome" and buildtype=="Official")', {
             'linux_dump_symbols%': 1,
           }],
         ],
       }],  # os_posix==1 and OS!="mac" and OS!="ios"
+      ['OS=="mac"', {
+        'icu_use_data_file_flag%': 1,
+      }],  # os=="mac"
       ['OS=="ios"', {
         'disable_nacl%': 1,
         'enable_background%': 0,
         'enable_task_manager%': 0,
         'icu_use_data_file_flag%': 1,
         'use_system_libxml%': 1,
         'use_system_sqlite%': 1,
         'locales==': [
           'ar', 'ca', 'cs', 'da', 'de', 'el', 'en-GB', 'en-US', 'es', 'es-MX',
           'fi', 'fr', 'he', 'hr', 'hu', 'id', 'it', 'ja', 'ko', 'ms', 'nb',
@@ skipping 882 matching lines @@
       ['native_discardable_memory==1', {
         'defines': ['DISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY'],
       }],
       ['native_memory_pressure_signals==1', {
         'defines': ['SYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE'],
       }],
       ['use_udev==1', {
         'defines': ['USE_UDEV'],
       }],
       ['icu_use_data_file_flag==1', {
         'defines': ['ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE'],

[Mark Mentovai, 2013/12/18 20:16:07]

Thinking about this some more, it really only needs to be defined when building
base/i18n/icu_util.cc. You can move this block into base/base.gyp for the
base_i18n target only. There’s no reason to set it for the rest of the Chrome
build, we’re just promoting more unnecessary widespread macro bloat.

       }, { # else icu_use_data_file_flag !=1
         'conditions': [
           ['OS=="win"', {
             'defines': ['ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_SHARED'],
           }, {
             'defines': ['ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC'],
           }],
         ],
       }],
       ['fastbuild!=0', {
@@ skipping 2574 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }