Issue 109006: Push the fix for http://crbug.com/9746 to the 1.1 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109006: Push the fix for http://crbug.com/9746 to the 1.1 branch. (Closed)

Created:
11 years, 7 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/1.1/

Visibility:
Public.

Description

Push the fix for http://crbug.com/9746 to the 1.1 branch. Committed: http://code.google.com/p/v8/source/detail?r=1854

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+171 lines, -26 lines)			Patch
M	src/api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mark-compact.h	View	4 chunks	+11 lines, -3 lines	0 comments	Download
M	src/mark-compact.cc	View	3 chunks	+58 lines, -18 lines	0 comments	Download
M	test/cctest/test-strings.cc	View	4 chunks	+101 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 7 months ago (2009-05-05 08:12:02 UTC) #3

I merged in the test case as well.  I needed to change
buffer->IsTwoByteRepresentation to StringShape(*buffer).IsTwoByteRepresentation.

Kasper, could you check that the test case looks OK.  The rest is unchanged.

Expand Messages | Collapse Messages