Merge NaClIPCAdapter::set_resolve_file_token_callback() into the constructor

Merge NaClIPCAdapter::set_resolve_file_token_callback() into the constructor

to ensure that the callback function is set before ConnectChannel()
is called. This prevents a potential race condition that could occur
if messages were pending when ipc_adapter->ConnectChannel() is called.

TEST=git cl try, ARC still works, PNaCl demo still works
BUG=nativeclient:3802
Committed: https://crrev.com/2f16fdd05314528ba83c7fdff61c442dc25f63e0
Cr-Commit-Position: refs/heads/master@{#325535}

[Yusuke Sato, 2015-04-16 20:37:49]

yusukes@chromium.org changed reviewers:
+ mseaborn@chromium.org

[Yusuke Sato, 2015-04-16 20:37:49]

Please take a look

[Mark Seaborn, 2015-04-16 20:51:21]

Can you explain the potential race condition in the commit message, please?  And
say that it could occur if messages were pending when
ipc_adapter->ConnectChannel() is called (though that shouldn't be possible since
we don't start NaCl untrusted code until later).

LGTM

https://codereview.chromium.org/1090043002/diff/1/components/nacl/loader/nacl...
File components/nacl/loader/nacl_ipc_adapter.h (right):

https://codereview.chromium.org/1090043002/diff/1/components/nacl/loader/nacl...
components/nacl/loader/nacl_ipc_adapter.h:91: // |resolve_file_token_cb| is a
callback to be invoked for resolving file
Maybe say "optional callback"?

https://codereview.chromium.org/1090043002/diff/1/components/nacl/loader/nacl...
File components/nacl/loader/nacl_listener.cc (right):

https://codereview.chromium.org/1090043002/diff/1/components/nacl/loader/nacl...
components/nacl/loader/nacl_listener.cc:142: scoped_refptr<NaClIPCAdapter>
SetUpIPCAdapter(
You can change this to return 'void' now.

[Yusuke Sato, 2015-04-16 21:25:03]

https://codereview.chromium.org/1090043002/diff/1/components/nacl/loader/nacl...
File components/nacl/loader/nacl_ipc_adapter.h (right):

https://codereview.chromium.org/1090043002/diff/1/components/nacl/loader/nacl...
components/nacl/loader/nacl_ipc_adapter.h:91: // |resolve_file_token_cb| is a
callback to be invoked for resolving file
On 2015/04/16 20:51:21, Mark Seaborn wrote:
> Maybe say "optional callback"?

Done.

https://codereview.chromium.org/1090043002/diff/1/components/nacl/loader/nacl...
File components/nacl/loader/nacl_listener.cc (right):

https://codereview.chromium.org/1090043002/diff/1/components/nacl/loader/nacl...
components/nacl/loader/nacl_listener.cc:142: scoped_refptr<NaClIPCAdapter>
SetUpIPCAdapter(
On 2015/04/16 20:51:21, Mark Seaborn wrote:
> You can change this to return 'void' now.

Done.

[Yusuke Sato, 2015-04-16 21:25:06]

The CQ bit was checked by yusukes@chromium.org

[Yusuke Sato, 2015-04-16 21:25:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
mseaborn@chromium.org
Link to the patchset: https://codereview.chromium.org/1090043002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2015-04-16 21:26:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1090043002/20001

[commit-bot: I haz the power, 2015-04-16 22:58:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-16 22:59:53]

Patchset 2 (id:??) landed as
https://crrev.com/2f16fdd05314528ba83c7fdff61c442dc25f63e0
Cr-Commit-Position: refs/heads/master@{#325535}