Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1090023004: Revert of [Chromoting] Enable remoting webapp main.html GN build. (Closed)

Created:
5 years, 8 months ago by maniscalco
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke, garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromoting] Enable remoting webapp main.html GN build. (patchset #5 id:80001 of https://codereview.chromium.org/1082083005/) Reason for revert: Suspected of breaking the build. For details, see https://code.google.com/p/chromium/issues/detail?id=477869 Original issue's description: > [Chromoting] Enable remoting webapp main.html GN build. > > The previous remoting webapp GN build files were not enabled and at > least 6 months out of date. This cl fixes the problem by bringing > the build rules up to date and enables the webapp build. > > It also starts to move all the remoting-specific build rules into > the remoting dir rather than having them in the main build.gn file. > > BUG= > > Committed: https://crrev.com/62ee8a9cfebbc8bdc037aaa3b37ebfbb45e02472 > Cr-Commit-Position: refs/heads/master@{#325551} TBR=dpranke@chromium.org,garykac@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/76302d920e57d6d0c368d827a78817aecea541ba Cr-Commit-Position: refs/heads/master@{#325556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -592 lines) Patch
M BUILD.gn View 3 chunks +13 lines, -2 lines 0 comments Download
M build/gn_migration.gypi View 1 chunk +11 lines, -1 line 0 comments Download
M remoting/BUILD.gn View 1 chunk +1 line, -58 lines 0 comments Download
M remoting/remoting_all.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
D remoting/remoting_enable.gni View 1 chunk +0 lines, -24 lines 0 comments Download
M remoting/remoting_enable.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/remoting_webapp_files.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/webapp/BUILD.gn View 2 chunks +166 lines, -15 lines 0 comments Download
D remoting/webapp/files.gni View 1 chunk +0 lines, -482 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
maniscalco
Created Revert of [Chromoting] Enable remoting webapp main.html GN build.
5 years, 8 months ago (2015-04-16 23:54:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090023004/1
5 years, 8 months ago (2015-04-16 23:55:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 23:57:51 UTC) #3
Dirk Pranke
lgtm.
5 years, 8 months ago (2015-04-16 23:58:34 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 23:59:42 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76302d920e57d6d0c368d827a78817aecea541ba
Cr-Commit-Position: refs/heads/master@{#325556}

Powered by Google App Engine
This is Rietveld 408576698