Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1090023002: Bump chrome_extensions.js (Closed)

Created:
5 years, 8 months ago by stevenjb
Modified:
5 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, vitalyp+closure_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bump chrome_extensions.js BUG=470262 Committed: https://crrev.com/62c7ca83f831570f4d106213cf3ee5b8c0bb79f3 Cr-Commit-Position: refs/heads/master@{#325569}

Patch Set 1 #

Patch Set 2 : Update with bump_compiler_version result #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -31 lines) Patch
M third_party/closure_compiler/externs/chrome_extensions.js View 1 6 chunks +195 lines, -31 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
stevenjb
The presubmit suggests changing README.chromium, but the script doesn't change it and I don't see ...
5 years, 8 months ago (2015-04-16 18:38:37 UTC) #2
stevenjb
Reconciled with script
5 years, 8 months ago (2015-04-16 19:05:07 UTC) #3
Dan Beam
lgtm
5 years, 8 months ago (2015-04-17 00:05:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090023002/20001
5 years, 8 months ago (2015-04-17 00:21:16 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-17 00:42:40 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 00:43:31 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/62c7ca83f831570f4d106213cf3ee5b8c0bb79f3
Cr-Commit-Position: refs/heads/master@{#325569}

Powered by Google App Engine
This is Rietveld 408576698