Put 'tools' directory at front of import path.

Put 'tools' directory at front of import path.

A change in the native_client/build/find_depot_tools, which
was presumably intended to be only for that project, got
picked up because the path creation puts that directory ahead
of the general tools directory.  This change makes sure that
"tools" modules always take precedence.

BUG=477848
Committed: https://crrev.com/e6f8f8395541e706e85c094ab52bfb394cc80847
Cr-Commit-Position: refs/heads/master@{#325851}

[bcwhite, 2015-04-16 18:07:25]

bcwhite@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, phosek@chromium.org, thakis@chromium.org

[bcwhite, 2015-04-16 18:07:26]

commit 11953a35fcd4f999b097a343bc49d89f94af21a8 broke the gyp_chromium under
CygWin because of this.  This fixes it but I'm unsure what peripheral effects it
could have.

[Petr Hosek, 2015-04-16 18:54:51]

On 2015/04/16 18:07:26, bcwhite wrote:
> commit 11953a35fcd4f999b097a343bc49d89f94af21a8 broke the gyp_chromium under
> CygWin because of this.  This fixes it but I'm unsure what peripheral effects
it
> could have.

I have prepared a CL 1087983005 which reflects the change made in
find_depot_tools.py.

[Nico, 2015-04-16 19:10:11]

Since there are two CLs for this (bcwhite's and phosek's), can you please file a
bug that describes the problem, with a stack? Then both CLs can target that.

Do we need both changes, or is just this one enough?

[Petr Hosek, 2015-04-16 19:21:14]

On 2015/04/16 19:10:11, Nico wrote:
> Since there are two CLs for this (bcwhite's and phosek's), can you please file
a
> bug that describes the problem, with a stack? Then both CLs can target that.
> 
> Do we need both changes, or is just this one enough?

AFAIK right now the call to add_depot_tools_to_path() in find_depot_tools.py is
failing since that functions was renamed. I'd be a little surprised if this
change was sufficient, but it's not impossible---it would suggest that the
add_depot_tools_to_path() call is not needed in the first place.

[Paweł Hajdan Jr., 2015-04-16 21:36:57]

LGTM

[bcwhite, 2015-04-16 23:06:44]

Nico, just one change is needed.  However, Petr's previous change (which caused
the breakage) made his edition of "find_depot_tools" different from the other
editions of this module elsewhere in the repository.  There are at least 3 of
them.

I'll file a bug.  Only one of mine & Petr's CL is necessary.  His is more
targeted and mine is more general.  I like the more general solution because it
means that we *know* that we'll always be accessing modules from the tools/
directory before anything else (now and in the future) but it's possible that
something has grown to depend on using a module duplicated elsewhere and with
different functionality.

[bcwhite, 2015-04-17 18:29:31]

On 2015/04/16 23:06:44, bcwhite wrote:
> Nico, just one change is needed.  However, Petr's previous change (which
caused
> the breakage) made his edition of "find_depot_tools" different from the other
> editions of this module elsewhere in the repository.  There are at least 3 of
> them.
> 
> I'll file a bug.  Only one of mine & Petr's CL is necessary.  His is more
> targeted and mine is more general.  I like the more general solution because
it
> means that we *know* that we'll always be accessing modules from the tools/
> directory before anything else (now and in the future) but it's possible that
> something has grown to depend on using a module duplicated elsewhere and with
> different functionality.

Ping?

[Petr Hosek, 2015-04-17 18:33:19]

lgtm

[bcwhite, 2015-04-20 13:37:00]

bcwhite@chromium.org changed reviewers:
+ jochen@chromium.org
- thakis@chromium.org

[bcwhite, 2015-04-20 13:37:01]

+jochen (OWNER)

[jochen (gone - plz use gerrit), 2015-04-20 13:40:21]

lgtm

[bcwhite, 2015-04-20 14:40:35]

The CQ bit was checked by bcwhite@chromium.org

[commit-bot: I haz the power, 2015-04-20 14:40:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1090013002/1

[commit-bot: I haz the power, 2015-04-20 16:00:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-20 16:00:57]

Patchset 1 (id:??) landed as
https://crrev.com/e6f8f8395541e706e85c094ab52bfb394cc80847
Cr-Commit-Position: refs/heads/master@{#325851}