Add SkTPin.

Add SkTPin.

Currently there exist SkScalarPin and SkPin32, and in a future change
another version is desired. This change introduces SkTPin and changes
SkScalarPin and SkPin32 to use it.

Committed: https://skia.googlesource.com/skia/+/fd0ecf46ce7736a86dd38d8cfc96078e588d10a3

[bungeman-skia, 2015-04-16 17:18:08]

bungeman@google.com changed reviewers:
+ djsollen@google.com, mtklein@google.com

[bungeman-skia, 2015-04-16 17:18:09]

This change was extracted from https://codereview.chromium.org/1027373002/ .

[bungeman-skia, 2015-04-16 17:18:21]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-04-16 17:18:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1090003002/1

[commit-bot: I haz the power, 2015-04-16 17:26:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 17:26:07]

Dry run: This issue passed the CQ dry run.

[djsollen, 2015-04-16 17:56:55]

https://codereview.chromium.org/1090003002/diff/1/include/core/SkTypes.h
File include/core/SkTypes.h (right):

https://codereview.chromium.org/1090003002/diff/1/include/core/SkTypes.h#newc...
include/core/SkTypes.h:403: template <typename T> static inline T SkTPin(T x, T
min, T max) {
return T&

[bungeman-skia, 2015-04-16 19:05:20]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[bungeman-skia, 2015-04-16 19:05:36]

https://codereview.chromium.org/1090003002/diff/1/include/core/SkTypes.h
File include/core/SkTypes.h (right):

https://codereview.chromium.org/1090003002/diff/1/include/core/SkTypes.h#newc...
include/core/SkTypes.h:403: template <typename T> static inline T SkTPin(T x, T
min, T max) {
On 2015/04/16 17:56:55, djsollen wrote:
> return T&

Done.

This was complicated somewhat by the need to return a reference to one of the
passed in values. I've verified that gcc and clang on amd64 produce exactly the
same output with the new pattern.

[commit-bot: I haz the power, 2015-04-16 19:05:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1090003002/20001

[djsollen, 2015-04-16 19:09:50]

lgtm

[commit-bot: I haz the power, 2015-04-16 19:12:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 19:12:20]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2015-04-16 19:18:01]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-04-16 19:18:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1090003002/20001

[commit-bot: I haz the power, 2015-04-16 19:18:32]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/fd0ecf46ce7736a86dd38d8cfc96078e588d10a3