Clean up and unify IsBoringSwitch().

Clean up and unify IsBoringSwitch().

R=thestig@chromium.org

Committed: https://crrev.com/149e1ffa0ef67f12cc5cb37c5e7d42cd3d70cf41
Cr-Commit-Position: refs/heads/master@{#325731}

[Robert Sesek, 2015-04-16 17:10:36]

The CQ bit was checked by rsesek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-16 17:11:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1089973002/1

[commit-bot: I haz the power, 2015-04-16 17:52:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 17:52:36]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Lei Zhang, 2015-04-16 18:21:44]

lgtm

[Lei Zhang, 2015-04-16 18:24:32]

https://codereview.chromium.org/1089973002/diff/1/chrome/common/crash_keys.cc
File chrome/common/crash_keys.cc (right):

https://codereview.chromium.org/1089973002/diff/1/chrome/common/crash_keys.cc...
chrome/common/crash_keys.cc:329: if (StartsWithASCII("/prefetch:"))
err, looks like you are missing a couple arguments.

https://codereview.chromium.org/1089973002/diff/1/chrome/common/crash_keys.cc...
chrome/common/crash_keys.cc:336: int len = (end == std::string::npos) ?
flag.length() - 2 : end - 2;
and this probably needs to be a size_t

[Robert Sesek, 2015-04-16 21:02:17]

Patchset #3 (id:40001) has been deleted

[Robert Sesek, 2015-04-16 22:00:30]

https://codereview.chromium.org/1089973002/diff/1/chrome/common/crash_keys.cc
File chrome/common/crash_keys.cc (right):

https://codereview.chromium.org/1089973002/diff/1/chrome/common/crash_keys.cc...
chrome/common/crash_keys.cc:329: if (StartsWithASCII("/prefetch:"))
On 2015/04/16 18:24:32, Lei Zhang (slow to respond) wrote:
> err, looks like you are missing a couple arguments.

Oops, got a bit aggressive with the deleting there.

https://codereview.chromium.org/1089973002/diff/1/chrome/common/crash_keys.cc...
chrome/common/crash_keys.cc:336: int len = (end == std::string::npos) ?
flag.length() - 2 : end - 2;
On 2015/04/16 18:24:32, Lei Zhang (slow to respond) wrote:
> and this probably needs to be a size_t

Done.

[Lei Zhang, 2015-04-16 22:02:30]

lgtm

https://codereview.chromium.org/1089973002/diff/60001/chrome/common/crash_key...
File chrome/common/crash_keys.cc (right):

https://codereview.chromium.org/1089973002/diff/60001/chrome/common/crash_key...
chrome/common/crash_keys.cc:296: "channel",
Can you mention this is suppose to be switches::kProcessChannelID ?

[Robert Sesek, 2015-04-17 20:12:55]

https://codereview.chromium.org/1089973002/diff/60001/chrome/common/crash_key...
File chrome/common/crash_keys.cc (right):

https://codereview.chromium.org/1089973002/diff/60001/chrome/common/crash_key...
chrome/common/crash_keys.cc:296: "channel",
On 2015/04/16 22:02:30, Lei Zhang wrote:
> Can you mention this is suppose to be switches::kProcessChannelID ?

I thought it was clear from the #if/#else, but done.

[Robert Sesek, 2015-04-17 20:12:58]

The CQ bit was checked by rsesek@chromium.org

[Robert Sesek, 2015-04-17 20:12:58]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1089973002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-04-17 20:14:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1089973002/80001

[commit-bot: I haz the power, 2015-04-17 22:56:40]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-04-17 22:57:35]

Patchset 4 (id:??) landed as
https://crrev.com/149e1ffa0ef67f12cc5cb37c5e7d42cd3d70cf41
Cr-Commit-Position: refs/heads/master@{#325731}