Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1089933004: DevTools: make DOMNodeIds a trivial wrapper around WeakIdentifierMap (Closed)

Created:
5 years, 8 months ago by caseq
Modified:
5 years, 8 months ago
Reviewers:
pfeldman
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: make DOMNodeIds a trivial wrapper around WeakIdentifierMap WeakIdentifierMap is intended for mapping between objects and their identifiers, and there's currently no reason to generate ids externally, so: - move id allocation/assignment to WeakIdentifierMap; - implement Oilpan version of WeakIdentifierMap; - move DOMNodeIds a trivial wrapper around WeakIdentifierMap; - get rid of WeakNodeMap header, move the definition to DOMNodeIds. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193960

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -86 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DOMNodeIds.h View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/dom/DOMNodeIds.cpp View 1 chunk +9 lines, -44 lines 0 comments Download
M Source/core/dom/Node.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/dom/WeakIdentifierMap.h View 4 chunks +76 lines, -13 lines 0 comments Download
D Source/core/dom/WeakNodeMap.h View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
caseq
5 years, 8 months ago (2015-04-16 17:54:53 UTC) #2
pfeldman
lgtm
5 years, 8 months ago (2015-04-17 15:59:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089933004/1
5 years, 8 months ago (2015-04-17 16:02:34 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 17:52:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193960

Powered by Google App Engine
This is Rietveld 408576698