Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 108993002: Revert "Revert "Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The… (Closed)

Created:
7 years ago by reed1
Modified:
7 years ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert "Revert "Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap.""" This reverts commit 5f035e90d6dea0139a4f204b634e7b7b3b4976d7. Reverting because it breaks chrome/blink due to new SkPixelRef constructor arg. BUG= Committed: https://code.google.com/p/skia/source/detail?r=12551

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -656 lines) Patch
M include/core/SkBitmap.h View 1 chunk +0 lines, -7 lines 0 comments Download
M include/core/SkBitmapDevice.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkImageInfo.h View 4 chunks +0 lines, -19 lines 0 comments Download
M include/core/SkMallocPixelRef.h View 1 chunk +16 lines, -35 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/core/SkPixelRef.h View 4 chunks +18 lines, -63 lines 0 comments Download
M include/gpu/GrSurface.h View 2 chunks +0 lines, -3 lines 0 comments Download
M include/gpu/SkGr.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/SkGrPixelRef.h View 2 chunks +6 lines, -5 lines 0 comments Download
M include/images/SkImageRef.h View 3 chunks +4 lines, -3 lines 0 comments Download
M include/images/SkImageRef_GlobalPool.h View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SamplePicture.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/core/SkBitmap.cpp View 4 chunks +9 lines, -85 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +18 lines, -17 lines 0 comments Download
M src/core/SkImageFilterUtils.cpp View 2 chunks +3 lines, -13 lines 0 comments Download
M src/core/SkMallocPixelRef.cpp View 3 chunks +20 lines, -111 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M src/core/SkPixelRef.cpp View 7 chunks +14 lines, -61 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrSurface.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 5 chunks +8 lines, -20 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +0 lines, -30 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 3 chunks +9 lines, -25 lines 0 comments Download
M src/image/SkDataPixelRef.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/image/SkDataPixelRef.cpp View 2 chunks +7 lines, -18 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 1 chunk +13 lines, -3 lines 0 comments Download
M src/images/SkImageRef.cpp View 7 chunks +20 lines, -11 lines 0 comments Download
M src/images/SkImageRef_GlobalPool.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/images/SkImageRef_ashmem.h View 1 chunk +1 line, -1 line 0 comments Download
M src/images/SkImageRef_ashmem.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/lazy/SkCachingPixelRef.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/lazy/SkCachingPixelRef.cpp View 5 chunks +15 lines, -19 lines 0 comments Download
M src/lazy/SkDiscardablePixelRef.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/lazy/SkDiscardablePixelRef.cpp View 3 chunks +15 lines, -23 lines 0 comments Download
M tests/PictureTest.cpp View 3 chunks +32 lines, -3 lines 0 comments Download
M tests/PixelRefTest.cpp View 1 chunk +11 lines, -13 lines 0 comments Download
M tests/SerializationTest.cpp View 2 chunks +3 lines, -16 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
reed1
7 years ago (2013-12-06 21:43:19 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r12551 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698