Chromium Code Reviews

Issue 1089913002: PPC: Array() in optimized code can create with wrong ElementsKind in corner cases. (Closed)

Created:
5 years, 8 months ago by MTBrandyberry
Modified:
5 years, 8 months ago
Reviewers:
michael_dawson, dstence, mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Array() in optimized code can create with wrong ElementsKind in corner cases. Port 13459c1ae3caa4cc546c522177bac5450a3252bf Original commit message: Calling new Array(JSObject::kInitialMaxFastElementArray) in optimized code makes a stub call that bails out due to the length. Currently, the bailout code a) doesn't have the allocation site, and b) wouldn't use it if it did because the length is perceived to be too high. This CL passes the allocation site to the stub call (rather than undefined), and alters the bailout code to utilize the feedback. R=mvstanton@chromium.org, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Committed: https://crrev.com/cc01cd94ab39078e99808e2cbb2d78c89a139033 Cr-Commit-Position: refs/heads/master@{#27895}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+8 lines, -1 line)
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +8 lines, -1 line 0 comments

Messages

Total messages: 11 (3 generated)
MTBrandyberry
Fix latest PPC breakage.
5 years, 8 months ago (2015-04-16 14:05:29 UTC) #1
dstence
On 2015/04/16 14:05:29, mtbrandyberry wrote: > Fix latest PPC breakage. lgtm
5 years, 8 months ago (2015-04-16 14:43:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089913002/1
5 years, 8 months ago (2015-04-16 14:44:42 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-16 14:44:46 UTC) #6
michael_dawson
On 2015/04/16 14:44:46, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
5 years, 8 months ago (2015-04-16 15:36:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089913002/1
5 years, 8 months ago (2015-04-16 15:37:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 16:13:28 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 16:13:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc01cd94ab39078e99808e2cbb2d78c89a139033
Cr-Commit-Position: refs/heads/master@{#27895}

Powered by Google App Engine