Refactoring bluetooth API code.

chrome/browser/chromeos/bluetooth/bluetooth_adapter_factory.h

Index: chrome/browser/chromeos/bluetooth/bluetooth_adapter_factory.h
diff --git a/chrome/browser/chromeos/bluetooth/bluetooth_adapter_factory.h b/chrome/browser/chromeos/bluetooth/bluetooth_adapter_factory.h
new file mode 100644
index 0000000000000000000000000000000000000000..79c9da19208ce2b7757190cf016917735ef644c4
--- /dev/null
+++ b/chrome/browser/chromeos/bluetooth/bluetooth_adapter_factory.h
@@ -0,0 +1,31 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_BLUETOOTH_BLUETOOTH_ADAPTER_FACTORY_H_
+#define CHROME_BROWSER_CHROMEOS_BLUETOOTH_BLUETOOTH_ADAPTER_FACTORY_H_
+
+#include <string>
+
+#include "base/memory/ref_counted.h"
+
+namespace chromeos {
+
+class BluetoothAdapter;
+
+class BluetoothAdapterFactory {

[keybuk, 2012/09/17 22:19:43]

Would a "Factory" be an appropriate class to add a method that returned a list
of available adapters?

[youngki, 2012/09/18 18:19:56]

Is that a new method that you want to add? I think if that's a static method and
cannot be contained in the interface, then we can put it here. Also we can
change the name "Factory" to something else if you think this doesn't represent
the Factory pattern.

[keybuk1, 2012/09/18 18:42:30]

yes, it's a method I have in a CL here that will be added; it sounds like it
belongs in this class, I'm not sure what pattern it represents or if "Factory"
is appropriate.

[youngki, 2012/09/19 01:13:55]

I think we could just leave the name "Factory" for now, and rename it later when
we come up with a better name.

+ public:
+  // Returns the shared instance for the default adapter, whichever that may
+  // be at the time. Use IsPresent() and the AdapterPresentChanged() observer
+  // method to determine whether an adapter is actually available or not.
+  static scoped_refptr<BluetoothAdapter> DefaultAdapter();
+
+  // Creates an instance for a specific adapter named by |address|, which
+  // may be the bluetooth address of the adapter or a device name such as
+  // "hci0".

[keybuk, 2012/09/17 22:19:43]

I'm not sure what to do about the "device name" bit - that's not cross-platform
at all!

[youngki, 2012/09/18 18:19:56]

We could move this method to BluetoothAdapterChromeOs for now since nobody is
calling this method. Let me know if that's what we should do.

[keybuk1, 2012/09/18 18:42:30]

Actually I think we should just drop that from the comment, having a "create for
this address" method is almost certainly still useful!

[youngki, 2012/09/19 01:13:55]

Done.

+  static BluetoothAdapter* Create(const std::string& address);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_BLUETOOTH_BLUETOOTH_ADAPTER_FACTORY_H_