Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 1089903002: Improve tessellating path rasterizer performance on dashed paths. (Closed)

Created:
5 years, 8 months ago by Stephen White
Modified:
5 years, 8 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Improve tessellating path rasterizer performance on dashed paths. With dashed paths, we get a lot of geometry on the same sort line. Since the vertices are sorted, it makes more sense to insert edges from the end (in sort order) than the beginning. This requires maintaining both the head and tail of the active edge list. This gives a ~20% perf improvement on tabl_digg.skp. BUG=skia:3733 Committed: https://skia.googlesource.com/skia/+/5b9f42c4d1ddc776334b3de676450f4cdaf607bd

Patch Set 1 #

Patch Set 2 : Coding style fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -37 lines) Patch
M src/gpu/GrTessellatingPathRenderer.cpp View 1 18 chunks +43 lines, -37 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Stephen White
Greg: PTAL. Thanks!
5 years, 8 months ago (2015-04-16 14:10:02 UTC) #2
egdaniel
lgtm. One general question, so dashing speeds up when you start at the end (as ...
5 years, 8 months ago (2015-04-16 18:27:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089903002/20001
5 years, 8 months ago (2015-04-16 18:35:13 UTC) #5
Stephen White
On 2015/04/16 18:27:10, egdaniel wrote: > lgtm. One general question, so dashing speeds up when ...
5 years, 8 months ago (2015-04-16 18:38:42 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 18:47:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5b9f42c4d1ddc776334b3de676450f4cdaf607bd

Powered by Google App Engine
This is Rietveld 408576698