Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 1089873003: Fix DCHECK failure when Manifest fetch has an Access Control error. (Closed)

Created:
5 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DCHECK failure when Manifest fetch has an Access Control error. This is also updating the test that wasn't able to catch this error because of unfortunate timing issues. BUG=474228 Committed: https://crrev.com/cd67622827724269db39c2ccb63d26e63bd41868 Cr-Commit-Position: refs/heads/master@{#325810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M content/browser/manifest/manifest_browsertest.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M content/renderer/fetchers/web_url_loader_client_impl.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
mlamouri (slow - plz ping)
Mike PTAL. This is a M43 Dev blocker.
5 years, 8 months ago (2015-04-19 09:54:39 UTC) #2
Mike West
LGTM.
5 years, 8 months ago (2015-04-19 12:20:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089873003/1
5 years, 8 months ago (2015-04-20 08:48:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/57388)
5 years, 8 months ago (2015-04-20 08:59:02 UTC) #7
mlamouri (slow - plz ping)
+jochen@, for some reasons, I thought mkwst@ was owing these files...
5 years, 8 months ago (2015-04-20 09:01:24 UTC) #9
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-20 09:03:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089873003/1
5 years, 8 months ago (2015-04-20 09:06:23 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-20 09:12:03 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 09:12:52 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd67622827724269db39c2ccb63d26e63bd41868
Cr-Commit-Position: refs/heads/master@{#325810}

Powered by Google App Engine
This is Rietveld 408576698