Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 1089873002: Remove support for AllowBackgroundModeFromRenderer group in BackgroundRendererProcesses experiment. (Closed)

Created:
5 years, 8 months ago by gab
Modified:
5 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for AllowBackgroundModeFromRenderer group in BackgroundRendererProcesses experiment. This group was only intended to be ran on early channels to show that we are tracking the right stats and ensure that the latest background mode experiment isn't bringing back the regressions that mode had previously brought (see issue 381820 and issue 398103). The analysis is complete and support for it in the client is no longer required (already ramped down server-side). (this is essentially a partial revert of https://codereview.chromium.org/926663002) BUG=459600 Committed: https://crrev.com/e194b5d49e4c0bc231e73acb4290e3d5a23fd97f Cr-Commit-Position: refs/heads/master@{#325445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -20 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
gab
John, PTAL. Thanks, Gab
5 years, 8 months ago (2015-04-16 13:11:52 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089873002/1
5 years, 8 months ago (2015-04-16 13:12:16 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/56796)
5 years, 8 months ago (2015-04-16 13:22:20 UTC) #6
jam
lgtm
5 years, 8 months ago (2015-04-16 14:48:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089873002/1
5 years, 8 months ago (2015-04-16 15:06:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 15:09:44 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 15:11:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e194b5d49e4c0bc231e73acb4290e3d5a23fd97f
Cr-Commit-Position: refs/heads/master@{#325445}

Powered by Google App Engine
This is Rietveld 408576698