Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1089853005: prepare to deprecate non phantom weak callbacks (Closed)

Created:
5 years, 8 months ago by dcarney
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

prepare to deprecate non phantom weak callbacks BUG= Committed: https://crrev.com/ccc8e4e4a217132f0b7820d28ef3f653b1150dad Cr-Commit-Position: refs/heads/master@{#28046}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -257 lines) Patch
M src/d8.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 27 chunks +140 lines, -243 lines 0 comments Download
M test/cctest/test-heap.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-24 11:31:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089853005/40001
5 years, 8 months ago (2015-04-24 11:38:56 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-24 12:35:19 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 12:35:34 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ccc8e4e4a217132f0b7820d28ef3f653b1150dad
Cr-Commit-Position: refs/heads/master@{#28046}

Powered by Google App Engine
This is Rietveld 408576698