Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1955)

Unified Diff: content/child/scheduler/worker_scheduler.h

Issue 1089833002: Introduce ChildScheduler as common base interface for WorkerScheduler and RendererScheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nits Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/scheduler/null_worker_scheduler.cc ('k') | content/child/scheduler/worker_scheduler_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/scheduler/worker_scheduler.h
diff --git a/content/child/scheduler/worker_scheduler.h b/content/child/scheduler/worker_scheduler.h
index 6d906267b89523825a058f4a852c2b6abb2fe9ba..7d1225135aff87ebb7f76719c22639717d5ac0ea 100644
--- a/content/child/scheduler/worker_scheduler.h
+++ b/content/child/scheduler/worker_scheduler.h
@@ -6,6 +6,7 @@
#define CONTENT_CHILD_SCHEDULER_WORKER_SCHEDULER_H_
#include "base/message_loop/message_loop.h"
+#include "content/child/scheduler/child_scheduler.h"
#include "content/child/scheduler/single_thread_idle_task_runner.h"
#include "content/common/content_export.h"
@@ -15,46 +16,15 @@ class MessageLoop;
namespace content {
-class CONTENT_EXPORT WorkerScheduler {
+class CONTENT_EXPORT WorkerScheduler : public ChildScheduler {
public:
- virtual ~WorkerScheduler();
+ ~WorkerScheduler() override;
static scoped_ptr<WorkerScheduler> Create(base::MessageLoop* message_loop);
// Must be called before the scheduler can be used. Does any post construction
// initialization needed such as initializing idle period detection.
virtual void Init() = 0;
- // Returns the default task runner.
- virtual scoped_refptr<base::SingleThreadTaskRunner> DefaultTaskRunner() = 0;
-
- // Returns the idle task runner. Tasks posted to this runner may be reordered
- // relative to other task types and may be starved for an arbitrarily long
- // time if no idle time is available.
- virtual scoped_refptr<SingleThreadIdleTaskRunner> IdleTaskRunner() = 0;
-
- // Returns true if a currently running idle task could exceed its deadline
- // without impacting user experience too much. This should only be used if
- // there is a task which cannot be pre-empted and is likely to take longer
- // than the largest expected idle task deadline. It should NOT be polled to
- // check whether more work can be performed on the current idle task after
- // its deadline has expired - post a new idle task for the continuation of the
- // work in this case.
- // Must be called from the worker's thread.
- virtual bool CanExceedIdleDeadlineIfRequired() const = 0;
-
- // Adds or removes a task observer from the scheduler. The observer will be
- // notified before and after every executed task. These functions can only be
- // called on the main thread.
- virtual void AddTaskObserver(
- base::MessageLoop::TaskObserver* task_observer) = 0;
- virtual void RemoveTaskObserver(
- base::MessageLoop::TaskObserver* task_observer) = 0;
-
- // Shuts down the scheduler by dropping any remaining pending work in the work
- // queues. After this call any work posted to the task runners will be
- // silently dropped.
- virtual void Shutdown() = 0;
-
protected:
WorkerScheduler();
DISALLOW_COPY_AND_ASSIGN(WorkerScheduler);
« no previous file with comments | « content/child/scheduler/null_worker_scheduler.cc ('k') | content/child/scheduler/worker_scheduler_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698