Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: content/renderer/scheduler/renderer_scheduler.h

Issue 1089833002: Introduce ChildScheduler as common base interface for WorkerScheduler and RendererScheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/child/scheduler/child_scheduler.h ('K') | « content/content_child.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/scheduler/renderer_scheduler.h
diff --git a/content/renderer/scheduler/renderer_scheduler.h b/content/renderer/scheduler/renderer_scheduler.h
index da21d815ae0708d4cfe7410666046dd26570d87c..7d08f311ffc2be74a0954cc4b968bc7f3489dfe7 100644
--- a/content/renderer/scheduler/renderer_scheduler.h
+++ b/content/renderer/scheduler/renderer_scheduler.h
@@ -6,6 +6,7 @@
#define CONTENT_RENDERER_SCHEDULER_RENDERER_SCHEDULER_H_
#include "base/message_loop/message_loop.h"
+#include "content/child/scheduler/child_scheduler.h"
#include "content/child/scheduler/single_thread_idle_task_runner.h"
#include "content/common/content_export.h"
#include "third_party/WebKit/public/web/WebInputEvent.h"
@@ -16,23 +17,15 @@ struct BeginFrameArgs;
namespace content {
-class CONTENT_EXPORT RendererScheduler {
+class CONTENT_EXPORT RendererScheduler : public ChildScheduler {
public:
- virtual ~RendererScheduler();
+ ~RendererScheduler() override;
static scoped_ptr<RendererScheduler> Create();
- // Returns the default task runner.
- virtual scoped_refptr<base::SingleThreadTaskRunner> DefaultTaskRunner() = 0;
-
// Returns the compositor task runner.
virtual scoped_refptr<base::SingleThreadTaskRunner>
CompositorTaskRunner() = 0;
- // Returns the idle task runner. Tasks posted to this runner may be reordered
- // relative to other task types and may be starved for an arbitrarily long
- // time if no idle time is available.
- virtual scoped_refptr<SingleThreadIdleTaskRunner> IdleTaskRunner() = 0;
-
// Returns the loading task runner. This queue is intended for tasks related
// to resource dispatch, foreground HTML parsing, etc...
virtual scoped_refptr<base::SingleThreadTaskRunner> LoadingTaskRunner() = 0;
@@ -78,36 +71,6 @@ class CONTENT_EXPORT RendererScheduler {
// Must be called from the main thread.
virtual bool IsHighPriorityWorkAnticipated() = 0;
- // Returns true if there is high priority work pending on the main thread
- // and the caller should yield to let the scheduler service that work. Note
- // that this is a stricter condition than |IsHighPriorityWorkAnticipated|,
- // restricted to the case where real work is pending.
- // Must be called from the main thread.
- virtual bool ShouldYieldForHighPriorityWork() = 0;
-
- // Returns true if a currently running idle task could exceed its deadline
- // without impacting user experience too much. This should only be used if
- // there is a task which cannot be pre-empted and is likely to take longer
- // than the largest expected idle task deadline. It should NOT be polled to
- // check whether more work can be performed on the current idle task after
- // its deadline has expired - post a new idle task for the continuation of the
- // work in this case.
- // Must be called from the main thread.
- virtual bool CanExceedIdleDeadlineIfRequired() const = 0;
-
- // Adds or removes a task observer from the scheduler. The observer will be
- // notified before and after every executed task. These functions can only be
- // called on the main thread.
- virtual void AddTaskObserver(
- base::MessageLoop::TaskObserver* task_observer) = 0;
- virtual void RemoveTaskObserver(
- base::MessageLoop::TaskObserver* task_observer) = 0;
-
- // Shuts down the scheduler by dropping any remaining pending work in the work
- // queues. After this call any work posted to the task runners will be
- // silently dropped.
- virtual void Shutdown() = 0;
-
// Suspends the timer queue and increments the timer queue suspension count.
// May only be called from the main thread.
virtual void SuspendTimerQueue() = 0;
« content/child/scheduler/child_scheduler.h ('K') | « content/content_child.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698