Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1089823004: Replace FX_NEW with new, remove tests from fpdfsdk (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -197 lines) Patch
M fpdfsdk/include/javascript/JS_Define.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/src/fpdf_dataavail.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_ext.cpp View 1 chunk +4 lines, -8 lines 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 7 chunks +25 lines, -29 lines 0 comments Download
M fpdfsdk/src/fpdf_progressive.cpp View 1 chunk +4 lines, -7 lines 0 comments Download
M fpdfsdk/src/fpdf_sysfontinfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 9 chunks +27 lines, -31 lines 0 comments Download
M fpdfsdk/src/fpdfdoc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfeditimg.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 6 chunks +15 lines, -19 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 2 chunks +5 lines, -23 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 12 chunks +24 lines, -29 lines 0 comments Download
M fpdfsdk/src/fsdk_baseannot.cpp View 8 chunks +13 lines, -19 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 3 chunks +8 lines, -9 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_FontMap.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Lei, for review.
5 years, 8 months ago (2015-04-16 22:13:36 UTC) #2
Tom Sepez
Rebased.
5 years, 8 months ago (2015-04-17 20:30:32 UTC) #3
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-17 20:56:34 UTC) #4
Tom Sepez
5 years, 8 months ago (2015-04-17 20:57:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
48606843d54c5f870d69627afedd574b58d65b3e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698