Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: Source/core/dom/Document.cpp

Issue 1089813004: Delay m_axObjectCache clearing during Document detach (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Keep clearAXObjectCache() at ~Document() Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index bb638c79e5ba62286b6ea9d474350d927ae45288..4b0ad253802576b8b5f73c518e91db4851d31603 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -2121,9 +2121,6 @@ void Document::detach(const AttachContext& context)
if (m_frame->loader().client()->sharedWorkerRepositoryClient())
m_frame->loader().client()->sharedWorkerRepositoryClient()->documentDetached(this);
- if (this == &axObjectCacheOwner())
- clearAXObjectCache();
-
stopActiveDOMObjects();
// FIXME: consider using ActiveDOMObject.
@@ -2153,9 +2150,11 @@ void Document::detach(const AttachContext& context)
m_focusedElement = nullptr;
if (frameHost())
frameHost()->chrome().focusedNodeChanged(oldFocusedElement.get(), nullptr);
-
}
+ if (this == &axObjectCacheOwner())
+ clearAXObjectCache();
+
m_layoutView = nullptr;
ContainerNode::detach(context);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698