Issue 1089783003: Fix use-after-free due to stale registered viewport layers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1089783003: Fix use-after-free due to stale registered viewport layers (Closed)

Created:
5 years, 8 months ago by enne (OOO)

Modified:
5 years, 8 months ago

Reviewers:
esprehn

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix use-after-free due to stale registered viewport layers The old willCloseLayerTreeView used to turn off accelerated compositing before deleting the layer tree view. The new code also needs to set a null root graphics layer to unregister viewport layers in the same way. This was caused by https://codereview.chromium.org/1078473002. R=esprehn@chromium.org BUG=478578

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	Source/web/WebViewImpl.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

enne (OOO)

5 years, 8 months ago (2015-04-23 21:05:39 UTC) #2

Nevermind.  Original patch was reverted, and I'll roll this in there.

Expand Messages | Collapse Messages