DescriptionRevert of Fix errors found in Mac gn component builds (patchset #10 id:180001 of https://codereview.chromium.org/1087873003/)
Reason for revert:
Suspected of breaking Mac GN, see https://codereview.chromium.org/1087873003
Original issue's description:
> Fix errors found in Mac gn component builds
>
> Mac gn component build fail because of missing frameworks and missing some other
> dependencies, and occasionally file list out of sync with the gyp counterpart:
> http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_dbg/builds/321/steps/compile/logs/stdio
>
> For instance, the frameworks linked in the components that sync depends on is not
> automatically linked into sync, thus revealing the issue.
>
> Committed: https://crrev.com/ae8297db22a6ca96652d42bd0cdc3deff17aba4a
> Cr-Commit-Position: refs/heads/master@{#325479}
BUG=477710
TBR=dpranke@google.com,dpranke@chromium.org,brettw@chromium.org,avi@chromium.org,toyoshim@chromium.org,piman@chromium.org,pavely@chromium.org,dalecurtis@chromium.org,jiangj@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/fe4be3daa9f58e38bfc44ef8c692eb59b4db0b29
Cr-Commit-Position: refs/heads/master@{#325483}
Patch Set 1 #
Created: 5 years, 8 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|