Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1089773003: Revert of Fix errors found in Mac gn component builds (Closed)

Created:
5 years, 8 months ago by maniscalco
Modified:
5 years, 8 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, piman+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix errors found in Mac gn component builds (patchset #10 id:180001 of https://codereview.chromium.org/1087873003/) Reason for revert: Suspected of breaking Mac GN, see https://codereview.chromium.org/1087873003 Original issue's description: > Fix errors found in Mac gn component builds > > Mac gn component build fail because of missing frameworks and missing some other > dependencies, and occasionally file list out of sync with the gyp counterpart: > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_dbg/builds/321/steps/compile/logs/stdio > > For instance, the frameworks linked in the components that sync depends on is not > automatically linked into sync, thus revealing the issue. > > Committed: https://crrev.com/ae8297db22a6ca96652d42bd0cdc3deff17aba4a > Cr-Commit-Position: refs/heads/master@{#325479} BUG=477710 TBR=dpranke@google.com,dpranke@chromium.org,brettw@chromium.org,avi@chromium.org,toyoshim@chromium.org,piman@chromium.org,pavely@chromium.org,dalecurtis@chromium.org,jiangj@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/fe4be3daa9f58e38bfc44ef8c692eb59b4db0b29 Cr-Commit-Position: refs/heads/master@{#325483}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -136 lines) Patch
M content/browser/BUILD.gn View 2 chunks +2 lines, -12 lines 0 comments Download
M content/common/BUILD.gn View 2 chunks +1 line, -10 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 chunk +0 lines, -9 lines 0 comments Download
M media/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M media/base/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M media/base/mac/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M media/cast/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
M media/cast/cast.gyp View 1 chunk +0 lines, -12 lines 0 comments Download
M sync/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M sync/sync.gyp View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/sudden_motion_sensor/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
M ui/accelerated_widget_mac/BUILD.gn View 1 chunk +1 line, -7 lines 0 comments Download
M ui/accelerated_widget_mac/accelerated_widget_mac.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/surface/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/surface/surface.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
maniscalco
Created Revert of Fix errors found in Mac gn component builds
5 years, 8 months ago (2015-04-16 18:54:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089773003/1
5 years, 8 months ago (2015-04-16 18:54:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 18:57:27 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 18:58:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe4be3daa9f58e38bfc44ef8c692eb59b4db0b29
Cr-Commit-Position: refs/heads/master@{#325483}

Powered by Google App Engine
This is Rietveld 408576698