Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1089763002: Oilpan: assert that new Persistents belong to Oilpan threads. (Closed)

Created:
5 years, 8 months ago by sof
Modified:
5 years, 8 months ago
Reviewers:
haraken
CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: assert that new Persistents belong to Oilpan threads. R=haraken BUG=477577 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193882

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove assert in ~PersistentBase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/platform/heap/Handle.h View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
haraken
LGTM
5 years, 8 months ago (2015-04-16 07:57:03 UTC) #2
sof
https://codereview.chromium.org/1089763002/diff/1/Source/platform/heap/Handle.h File Source/platform/heap/Handle.h (right): https://codereview.chromium.org/1089763002/diff/1/Source/platform/heap/Handle.h#newcode166 Source/platform/heap/Handle.h:166: ASSERT(ThreadState::current()); The assert in the dtor cannot be used, ...
5 years, 8 months ago (2015-04-16 11:08:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089763002/20001
5 years, 8 months ago (2015-04-16 14:35:46 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 16:02:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193882

Powered by Google App Engine
This is Rietveld 408576698