Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1516)

Issue 1089703002: Convert downloads_page.css to downloads_page_style.html. See http://goo.gl/vIGSCO for more informat… (Closed)

Created:
5 years, 8 months ago by Kyle Horimoto
Modified:
5 years, 8 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert downloads_page.css to downloads_page_style.html. See http://goo.gl/vIGSCO for more information. BUG=477154 Committed: https://crrev.com/4c245674a34ba99e6bb1dc243c1d4d70fba8d422 Cr-Commit-Position: refs/heads/master@{#325368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
D chrome/browser/resources/settings/downloads_page/downloads_page.css View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/resources/settings/downloads_page/downloads_page.html View 1 chunk +2 lines, -1 line 0 comments Download
A + chrome/browser/resources/settings/downloads_page/downloads_page_style.html View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Kyle Horimoto
5 years, 8 months ago (2015-04-16 00:24:28 UTC) #2
michaelpg
lgtm
5 years, 8 months ago (2015-04-16 00:28:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089703002/1
5 years, 8 months ago (2015-04-16 00:29:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 01:28:17 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 01:29:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c245674a34ba99e6bb1dc243c1d4d70fba8d422
Cr-Commit-Position: refs/heads/master@{#325368}

Powered by Google App Engine
This is Rietveld 408576698