Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1089693002: remove another old analyzer workaround (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/core.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/codegen/js_codegen.dart
diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart
index a3d3e6f0e61b254fce0d4fdb3fb4aa3eee9b74c5..ebfe8d27528addc34a8889e6d9e242a637ed802d 100644
--- a/lib/src/codegen/js_codegen.dart
+++ b/lib/src/codegen/js_codegen.dart
@@ -1102,14 +1102,10 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {
var typeArgs = null;
if (type is ParameterizedType) {
- // TODO(jmesserly): this is a workaround for an analyzer bug, see:
- // https://github.com/dart-lang/dev_compiler/commit/a212d59ad046085a626dd8d16881cdb8e8b9c3fa
- if (type is! FunctionType || element is FunctionTypeAlias) {
- var args = type.typeArguments;
- if (args.any((a) => a != types.dynamicType)) {
- name = '$name\$';
- typeArgs = args.map(_emitTypeName);
- }
+ var args = type.typeArguments;
+ if (args.any((a) => a != types.dynamicType)) {
+ name = '$name\$';
+ typeArgs = args.map(_emitTypeName);
}
}
@@ -1277,7 +1273,7 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {
var named = <JS.Property>[];
for (var arg in node.arguments) {
if (arg is NamedExpression) {
- named.add(visitNamedExpression(arg));
+ named.add(_visit(arg));
} else {
args.add(_visit(arg));
}
« no previous file with comments | « lib/runtime/dart/core.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698