Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1089683003: Files.app: Prevent dragging files while renaming is in progress. (Closed)

Created:
5 years, 8 months ago by fukino
Modified:
5 years, 8 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Prevent dragging files while renaming is in progress. BUG=chrome-os-partner:37273 TEST=manual test Committed: https://crrev.com/2fad4e2242eb0d2f73eb57f8165d089377f7c68e Cr-Commit-Position: refs/heads/master@{#325400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_transfer_controller.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
fukino
Could you take a look? Thanks!
5 years, 8 months ago (2015-04-16 06:20:52 UTC) #2
hirono
lgtm!
5 years, 8 months ago (2015-04-16 07:24:47 UTC) #3
fukino
On 2015/04/16 07:24:47, hirono wrote: > lgtm! Thanks!
5 years, 8 months ago (2015-04-16 07:25:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089683003/1
5 years, 8 months ago (2015-04-16 07:25:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 07:54:30 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 07:56:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fad4e2242eb0d2f73eb57f8165d089377f7c68e
Cr-Commit-Position: refs/heads/master@{#325400}

Powered by Google App Engine
This is Rietveld 408576698