Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2124)

Issue 1089673002: [telemetry] Add in entry points to find_dependencies with no arguments. (Closed)

Created:
5 years, 8 months ago by dtu
Modified:
5 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Add in entry points to find_dependencies with no arguments. Running modulefinder with just __init__ doesn't include everything, and having the entry points is more likely to include everything. BUG=None. TEST=tools/telemetry/find_dependencies | wc -l # == 3770, not 3719 Committed: https://crrev.com/1eaed7d18574e33f9713f984cd098cdc5263df20 Cr-Commit-Position: refs/heads/master@{#325352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M tools/telemetry/telemetry/util/find_dependencies.py View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dtu
5 years, 8 months ago (2015-04-15 21:43:29 UTC) #2
nednguyen
lgtm
5 years, 8 months ago (2015-04-15 21:52:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089673002/1
5 years, 8 months ago (2015-04-15 21:55:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 00:02:28 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 00:03:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1eaed7d18574e33f9713f984cd098cdc5263df20
Cr-Commit-Position: refs/heads/master@{#325352}

Powered by Google App Engine
This is Rietveld 408576698