Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1089643002: Make ScrollUpdate LatencyInfo's sequence number less likely to have conflicts (Closed)

Created:
5 years, 8 months ago by Yufeng Shen (Slow to review)
Modified:
5 years, 8 months ago
Reviewers:
Sami
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ScrollUpdate LatencyInfo's sequence number less likely to have conflicts BUG=472073 Committed: https://crrev.com/91de260e76a7fab71e5f86749d5eea9ec371663b Cr-Commit-Position: refs/heads/master@{#325458}

Patch Set 1 #

Total comments: 2

Patch Set 2 : cast to uint64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M cc/trees/latency_info_swap_promise_monitor.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Yufeng Shen (Slow to review)
5 years, 8 months ago (2015-04-15 18:53:49 UTC) #2
Sami
Thanks for fixing this! lgtm with a question. https://codereview.chromium.org/1089643002/diff/1/cc/trees/latency_info_swap_promise_monitor.cc File cc/trees/latency_info_swap_promise_monitor.cc (right): https://codereview.chromium.org/1089643002/diff/1/cc/trees/latency_info_swap_promise_monitor.cc#newcode75 cc/trees/latency_info_swap_promise_monitor.cc:75: (std::abs(reinterpret_cast<int64>(this)) ...
5 years, 8 months ago (2015-04-16 10:55:44 UTC) #3
Yufeng Shen (Slow to review)
https://codereview.chromium.org/1089643002/diff/1/cc/trees/latency_info_swap_promise_monitor.cc File cc/trees/latency_info_swap_promise_monitor.cc (right): https://codereview.chromium.org/1089643002/diff/1/cc/trees/latency_info_swap_promise_monitor.cc#newcode75 cc/trees/latency_info_swap_promise_monitor.cc:75: (std::abs(reinterpret_cast<int64>(this)) << 32)) | On 2015/04/16 10:55:44, Sami wrote: ...
5 years, 8 months ago (2015-04-16 15:19:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089643002/20001
5 years, 8 months ago (2015-04-16 15:20:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-16 17:00:39 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 17:01:43 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/91de260e76a7fab71e5f86749d5eea9ec371663b
Cr-Commit-Position: refs/heads/master@{#325458}

Powered by Google App Engine
This is Rietveld 408576698