Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1089623002: Revert of Simplify DoParseProgram (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
Reviewers:
wingo, marja
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Simplify DoParseProgram (patchset #2 id:20001 of https://codereview.chromium.org/1058363003/) Reason for revert: [Sheriff] Changes some layout tests on all platforms, e.g.: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2032/builds/2543 Original issue's description: > Simplify DoParseProgram > > DoParseProgram doesn't appear to need to receive toplevel scopes as > arguments; it can properly set the end_position of the scopes to the > scanner's position after parsing is complete. > > R=marja@chromium.org > BUG= > LOG=N > > Committed: https://crrev.com/8da9252f61d3c499a78b0b94299c314b2eb0b0c8 > Cr-Commit-Position: refs/heads/master@{#27847} TBR=marja@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/c85b22486a2d3066dec960b5073d6b2a07a7482d Cr-Commit-Position: refs/heads/master@{#27856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -25 lines) Patch
M src/parser.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/parser.cc View 7 chunks +34 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Simplify DoParseProgram
5 years, 8 months ago (2015-04-15 17:20:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089623002/1
5 years, 8 months ago (2015-04-15 17:20:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 17:20:35 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 17:20:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c85b22486a2d3066dec960b5073d6b2a07a7482d
Cr-Commit-Position: refs/heads/master@{#27856}

Powered by Google App Engine
This is Rietveld 408576698