Android: Use external storage for test data.

Android: Use external storage for test data.

Also increasing priority for logging test markers.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154786

[nilesh, 2012-08-29 23:08:21]

rsleevi: Please look at net/
mark: Please look at base/
Yaron: everything :)

[Yaron, 2012-08-30 01:06:34]

lgtm

Update cl description to also mention increase in log priority

[nilesh, 2012-08-30 01:35:36]

On 2012/08/30 01:06:34, Yaron wrote:
> lgtm
> 
> Update cl description to also mention increase in log priority

Done.

[Ryan Sleevi, 2012-08-30 02:49:03]

net/ LGTM as a functional change, but question about making it better below.

http://codereview.chromium.org/10896050/diff/1/net/test/remote_test_server.cc
File net/test/remote_test_server.cc (right):

http://codereview.chromium.org/10896050/diff/1/net/test/remote_test_server.cc...
net/test/remote_test_server.cc:32: const char kTestServerPortInfoFile[] =
"/sdcard/net-test-server-ports";
Is there a reason this doesn't make use of base_paths_android.cc? Can it?

[Mark Mentovai, 2012-08-30 02:52:29]

http://codereview.chromium.org/10896050/diff/1/base/test/test_support_android.cc
File base/test/test_support_android.cc (right):

http://codereview.chromium.org/10896050/diff/1/base/test/test_support_android...
base/test/test_support_android.cc:149: // For tests we use external storage for
app data.
Don’t say “we.”

[nilesh, 2012-08-30 17:21:55]

Addressed comments. PTAL.

http://codereview.chromium.org/10896050/diff/1/base/test/test_support_android.cc
File base/test/test_support_android.cc (right):

http://codereview.chromium.org/10896050/diff/1/base/test/test_support_android...
base/test/test_support_android.cc:149: // For tests we use external storage for
app data.
On 2012/08/30 02:52:29, Mark Mentovai wrote:
> Don’t say “we.”

Done.

http://codereview.chromium.org/10896050/diff/1/net/test/remote_test_server.cc
File net/test/remote_test_server.cc (right):

http://codereview.chromium.org/10896050/diff/1/net/test/remote_test_server.cc...
net/test/remote_test_server.cc:32: const char kTestServerPortInfoFile[] =
"/sdcard/net-test-server-ports";
On 2012/08/30 02:49:03, Ryan Sleevi wrote:
> Is there a reason this doesn't make use of base_paths_android.cc? Can it?

Done.

[nilesh, 2012-08-31 17:39:50]

Mark: ping.

[Mark Mentovai, 2012-09-04 15:50:03]

LGTM

[commit-bot: I haz the power, 2012-09-04 16:33:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10896050/17002

[commit-bot: I haz the power, 2012-09-04 18:50:50]

Change committed as 154786